Allow shooting out lights in the lab. #35724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
|
Maybe add some chance to hit instead of guaranteed? |
ZhilkinSerg
added
<Enhancement / Feature>
|
Gave it a 1 in 3 chance. At this point in the code there is no information about accuracy/distance/etc. available. |
|
This is allowing "overhead lights" to block shots intended for targets on the ground |
No? |
|
As far as I remember this only gets called when shooting at an empty tile or the monster was missed with the shot. |
|
Ah, apologies if I was mistaken. I just noticed this behavior for the first time and assumed it had something to do with this pull.
|
|
I guess you missed your target, so you hit a terrain instead. It could happen with other terrains too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: Features "Allow shooting out lights in the lab."Purpose of change
https://www.reddit.com/r/cataclysmdda/comments/dz1e8x/as_someone_who_spent_a_lot_of_time_in_labs/
Describe the solution
Added entry for
t_thconc_floor_olightterrain to huge if else block.Describe alternatives you've considered
Moving that whole if else mess into json. Was too lazy to do so.
Testing
Shot at light. Light dead.