-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Regional terrain expansion #35669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Regional terrain expansion #35669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweak regular groundcover while at it.
… into regional-terrain1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
[JSON]
Changes (can be) made in JSON
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Adds a few more biome-dependent terrain types"
Purpose of change
#35627 adds the ability to specify terrain types by region. This is extremely useful for mapping and will allow maps to vary by biome, as well as limit needing long lists of terrain types in maps.
More specific subgroups of trees and flowers make it a little easier to use regional terrain in gardens and urban settings.
Describe the solution
Adds the following new pseudo-terrains:
I am also experimenting with using these regional terrains to generate the list of cover for fields, forests, and such in the region. Seems logical, since they should also follow the regional breakdown and it will make it much more simple to create new biomes this way.
Describe alternatives you've considered
I'm sure there would be other ways to break these down, but this seems reasonable to me.
Testing
Tested. Doesn't throw errors. Fields don't look significantly changed by the adjustment in regional map settings, although they now spawn dead grass and there's a slight difference in the overall balance of terrain and furniture appearing of course.