Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GF recipes mod update: Remove unnecessary overrides, correct some others #29541

Merged
merged 2 commits into from
Apr 14, 2019

Conversation

esotericist
Copy link
Contributor

@esotericist esotericist commented Apr 13, 2019

Summary

SUMMARY: Mods "Fix GF recipes mod recipes overriding vanilla, plus other fixes"

Purpose of change

The original impetus to look at this mod was a report that imitation peanut butter wasn't allow in PB&J sandwiches (and associated variants). It was initially clear that the peanut butter sandwiches were being needlessly overridden (and the gluten free variants lacked imitation PB), but further investigation showed additional recipe mismatches against vanilla with the mod enabled.

Describe the solution

Removed almost all overrides, added imitation peanut butter to appropriate recipes, tweaked a couple of remaining overrides to be more valid.

Describe alternatives you've considered

The mod could use a more thorough examination of the remaining recipes for consonance with vanilla.

Some of the overrides still present in the mod have an interesting conceptual basis that might be worth considering (wrt the concept of 'cornmeal' being expanded to include e.g. acorns, as a proxy to a gluten free flour concept) in the core game, but that is a task for someone more invested in food than me.

@esotericist
Copy link
Contributor Author

Stand by, this is a bigger problem than I thought

@esotericist esotericist changed the title GF recipes mod update: Remove PB sandwich overrides, add imitation PB GF recipes mod update: Remove unnecessary overrides, correct some others Apr 13, 2019
@esotericist
Copy link
Contributor Author

Okay. More thorough work done, this should be ready.

@mlangsdorf mlangsdorf added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks labels Apr 13, 2019
@kevingranade
Copy link
Member

To be clear, the issue is that the vanilla (heh) versions of these recipes meet the needs of GF recipes now when crafted with GF components, right?

@esotericist
Copy link
Contributor Author

To be clear, the issue is that the vanilla (heh) versions of these recipes meet the needs of GF recipes now when crafted with GF components, right?

Literally the problem with the overrides I deleted was that they were direct C&Ps of old recipes that hadn't been updated when vanilla's were. That's it. The GF recipes didn't depend on them at all (because all of the recipes in question were unquestionably not GF). I have no idea why they were in there in the first place.

There should be no impact to the theoretical contamination (beyond what is implicit beyond possibly not keeping your cooking space properly sanitized, which lol we are not going to model).

@kevingranade kevingranade merged commit 55a2ed7 into CleverRaven:master Apr 14, 2019
@esotericist esotericist deleted the fix-gf-mod branch April 17, 2019 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants