Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make examine_action assign multiple actions #65552

Open
GuardianDll opened this issue May 9, 2023 · 8 comments
Open

Make examine_action assign multiple actions #65552

GuardianDll opened this issue May 9, 2023 · 8 comments
Labels
Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA <Suggestion / Discussion> Talk it out before implementing

Comments

@GuardianDll
Copy link
Member

Is your feature request related to a problem? Please describe.

Doors have few different actions, that they can have - locked_object, locked_object_pickable and door_peephole. Alas, only one of them can be used at the furniture defintion, which means you need to manually activate a tool to perform action with it (which a lot of people don't know you can)

Solution you would like.

Make examine_action accept a range of actions you can perform with it

"examine_action": { "locked_object", "locked_object_pickable", "door_peephole" }

Describe alternatives you have considered.

No response

Additional context

No response

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jun 8, 2023
@Procyonae
Copy link
Contributor

Can EOCs call examine actions?

@GuardianDll
Copy link
Member Author

No, and it's wrong way to resolve this issue

@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Jul 3, 2023
@Procyonae
Copy link
Contributor

Why, wouldn't the EOC selector stuff would be ideal?

@GuardianDll
Copy link
Member Author

EoC is a tool, not a duct tape we can apply everywhere where code doesn't work
What if someone need to make action use EoC, do they need to make EoC in EoC? What if multiple EoCs? Amount of json to support it would bloat exponentially, when the actual change is just make examine_action accept range

@Procyonae
Copy link
Contributor

...what are you on about? I'm saying it would make sense to make it take an "examine_action": { "EOC_examine_action": [ "locked_object", "locked_object_pickable", "door_peephole" ] that uses the EoC selector stuff as opposed to hardcoding new selector behaviour to allow it to take a range

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Aug 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@GuardianDll GuardianDll reopened this May 8, 2024
@GuardianDll GuardianDll added Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA and removed stale Closed for lack of activity, but still valid. labels May 8, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jun 7, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 7, 2024
@Procyonae Procyonae added (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter and removed stale Closed for lack of activity, but still valid. labels Jul 10, 2024
@Procyonae Procyonae reopened this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

2 participants