Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Explain use of message categories, especially info vs neutral #52147

Open
NetSysFire opened this issue Oct 6, 2021 · 4 comments
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter <Suggestion / Discussion> Talk it out before implementing

Comments

@NetSysFire
Copy link
Member

Describe the bug

There is no documentation on how message categories in p->add_msg_if_player() should be used.

Steps To Reproduce

n/a

Expected behavior

Most are self-explanatory but it would be great if they could still be explained somewhere. In particular I found it hard to distinguish between m_info and m_neutral and I think there should be some official guidance about that somewhere.

Screenshots

No response

Versions and configuration

n/a

Additional context

No response

@BrettDong BrettDong added <Suggestion / Discussion> Talk it out before implementing <Documentation> Design documents, internal info, guides and help. labels Oct 7, 2021
@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Apr 27, 2022
@NetSysFire NetSysFire added the <Enhancement / Feature> New features, or enhancements on existing label Apr 27, 2022
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Apr 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Dec 6, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2023
@NetSysFire NetSysFire reopened this Jan 5, 2023
@NetSysFire NetSysFire added [C++] Changes (can be) made in C++. Previously named `Code` (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter and removed stale Closed for lack of activity, but still valid. labels Jan 5, 2023
@GuardianDll
Copy link
Member

@NetSysFire
Copy link
Member Author

Ideally in our Manual of Style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing (P4 - Low) Low priority issues: things which are e.g exotic, minor and/or hard to encounter <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

3 participants