Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schema to align with v3 spec #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update schema to align with v3 spec #47

wants to merge 2 commits into from

Conversation

mlezeng
Copy link
Contributor

@mlezeng mlezeng commented Dec 9, 2020

  • Meta: district's district contact should become a user ID instead of a district admin object.
    • Update District/properties/district_contact to type: string x-validation: true
  • Add type to resources/{id}/users/get/parameters/1
  • Remove relationship, students, and type from Contact properties
  • Remove AdminName definition because this is not referenced?
  • Remove email from Teacher
  • In user definitions, rename id to legacy_id for
    • Contact,
    • DistrictAdmin,
    • Staff,
    • Student,
    • Teacher
  • Change Users field per role to single role field with list of roles
  • Remove contact, staff from /resources/{id}/users/get/parameters/1
  • Change description for /users/{id}/mystudents to "Returns the student users for a teacher or contact user"

Update schema to align with v3 spec
04ea275 
- [x] Meta: district's district contact should become a user ID instead of a district admin object.
	- [x] Update District/properties/district_contact to `type: string` `x-validation: true`
- [x] Add `type` to resources/{id}/users/get/parameters/1
- [x] Remove `relationship`, `students`, and `type` from Contact properties
- [x] Remove AdminName definition because this is not referenced?
- [x] Remove `email` from Teacher
- [x] In user definitions, rename `id` to `legacy_id` for 
	- [x] Contact, 
	- [x] DistrictAdmin, 
	- [x] Staff, 
	- [x] Student, 
	- [x] Teacher
- [x] Change Users field per role to single role field with list of roles
- [x] Remove `contact`, `staff` from /resources/{id}/users/get/parameters/1
- [x] Change description for /users/{id}/mystudents to "Returns the student users for a teacher or contact user"
@clever-saylor clever-saylor mentioned this pull request Dec 9, 2020
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meliaj meliaj Awaiting requested review from meliaj

@clever-saylor clever-saylor Awaiting requested review from clever-saylor

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlezeng @clever-saylor