Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYNC-2075 More edits #48

Merged
merged 1 commit into from
Dec 9, 2020
Merged

SYNC-2075 More edits #48

merged 1 commit into from
Dec 9, 2020

Conversation

clever-saylor
Copy link
Contributor

@clever-saylor clever-saylor commented Dec 9, 2020 •
edited
Loading

See #47 for set of changes to make (but this time, to full-v3.yml and trickled down to the generated files).
SYNC-2075
Schema in AirTable

  • Meta: district's district contact should become a user ID instead of a district admin object.
    • Update District/properties/district_contact to type: string x-validation: true
  • Add type to resources/{id}/users/get/parameters/1
  • Remove relationship, students, and type from Contact properties
  • Remove AdminName definition because this is not referenced?
  • Remove email from Teacher
  • In user definitions, rename id to legacy_id for
    • Contact,
    • DistrictAdmin,
    • Staff,
    • Student,
    • Teacher
  • Change Users field per role to single role field with list of roles
  • Remove contact, staff from /resources/{id}/users/get/parameters/1
  • Change description for /users/{id}/mystudents to "Returns the student users for a teacher or contact user"

@clever-saylor clever-saylor changed the title MLE made me SYNC-2075 More edits Dec 9, 2020
mlezeng
mlezeng approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@mlezeng mlezeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 :shipit:

@clever-saylor clever-saylor merged commit f721046 into master Dec 9, 2020
@clever-saylor clever-saylor deleted the SYNC-2075-more-edits branch December 9, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlezeng mlezeng mlezeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clever-saylor @mlezeng