-
Notifications
You must be signed in to change notification settings - Fork 5
Rename makefile to Makefile and edit
#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9e8a7af to
15ef0ea
Compare
makefile to Makefilemakefile to Makefile and edit
|
Hi @Vaelatern I really appreciate anyone taking the time out of their day to just commit to my repo's, thanks a lot! |
Whoops, didn't mean to approve just yet
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be at the top/bottom of the Makefile, it tells make that the targets listed don't create anything.
.PHONY: all clean uninstall install15ef0ea to
0ec1da1
Compare
0ec1da1 to
7e20aad
Compare
Itai-Nelken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
@Vaelatern I think you need to sign the commits for us to be able to merge, is that correct @CleanMachine1? |
This Makefile both follows convention better, and uses sane defaults For example, make has default rules for building. All projects, unless they are certain, should use them. So this does. This also adds `install` without falling into the `-D` portability trap. This program should never be accepted as a package to any Linux distribution.
7e20aad to
3448457
Compare
|
I dont remember turning that rule on. I'll merge as administrator and also disable that rule |
|
@Vaelatern Its signed however you need to upload the key here |
|
Thanks for contributing! |
* Better makefile (CleanMachine1#21) * fix github actions (CleanMachine1#24) * Cleaned README (CleanMachine1#25) * Added version reference in README * PKGBUILD for Arch users (CleanMachine1#26) * README * Added version refernace in README * Added Arch PKGBUILD file * .gitignore to remove files made with makepkg * Added PKGBUILD install for arch in README * Other * added make to depends * Update PKGBUILD Co-authored-by: Itai Nelken <70802936+Itai-Nelken@users.noreply.github.com> * added wildcard for .gitignore Co-authored-by: Itai Nelken <70802936+Itai-Nelken@users.noreply.github.com> * Added build passing badge Co-authored-by: Itai Nelken <70802936+Itai-Nelken@users.noreply.github.com> * makefile: adopted `PREFIX` (CleanMachine1#30) * Changed PKGBUILD sha256sums (CleanMachine1#31) * Skipping sums (CleanMachine1#32) * Changed PKGBUILD sha256sums * SKIPED SHA256 * minor error * Added PKGBUILD sums (CleanMachine1#33) * Add comments (CleanMachine1#23) * Add comments that explain what the code does Signed-off-by: Itai-Nelken <itainelken@gmail.com> * Update dollarskip.c Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> * Add space before comment text Signed-off-by: Itai-Nelken <itainelken@gmail.com> Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> * Add yay to README (CleanMachine1#39) * Add yayto install * Add more info * README: grammatical error fix (CleanMachine1#40) * Repair makefile (CleanMachine1#41) This Makefile both follows convention better, and uses sane defaults For example, make has default rules for building. All projects, unless they are certain, should use them. So this does. This also adds `install` without falling into the `-D` portability trap. This program should never be accepted as a package to any Linux distribution. * Fix workflow (CleanMachine1#42) * rewrite Signed-off-by: Itai-Nelken <itainelken@gmail.com> * Check that there is enough space for everything, not just arguments Signed-off-by: Itai-Nelken <itainelken@gmail.com> * Update dollarskip.c Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> * fix comment * Update dollarskip.c * Update dollarskip.c * Update dollarskip.c * Fix PKGBUILD and update it to latest release (CleanMachine1#44) * Fix PKGBUILD and update it to latest release Signed-off-by: Itai-Nelken <itainelken@gmail.com> * The actual fix Signed-off-by: Itai-Nelken <itainelken@gmail.com> * Update PKGBUILD Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> Co-authored-by: pixel <35269695+pixelcmtd@users.noreply.github.com> Co-authored-by: Toyam Cox <aviator45003@gmail.com>
This Makefile both follows convention better, and uses sane defaults
For example, make has default rules for building.
All projects, unless they are certain, should use them.
So this does.
This also adds
installwithout falling into the-Dportability trap.