Skip to content

Conversation

@Vaelatern
Copy link
Contributor

This Makefile both follows convention better, and uses sane defaults

For example, make has default rules for building.

All projects, unless they are certain, should use them.

So this does.

This also adds install without falling into the -D portability trap.

@CleanMachine1 CleanMachine1 changed the title Repair makefile Rename makefile to Makefile Nov 17, 2021
@CleanMachine1 CleanMachine1 changed the title Rename makefile to Makefile Rename makefile to Makefile and edit Nov 17, 2021
CleanMachine1
CleanMachine1 previously approved these changes Nov 17, 2021
@CleanMachine1
Copy link
Owner

Hi @Vaelatern

I really appreciate anyone taking the time out of their day to just commit to my repo's, thanks a lot!

@CleanMachine1 CleanMachine1 dismissed their stale review November 17, 2021 17:28

Whoops, didn't mean to approve just yet

@Vaelatern
Copy link
Contributor Author

$ make clean
rm -f dollarskip
$ make
cc -g    dollarskip.c   -o dollarskip
$ make clean
rm -f dollarskip
$ make install
cc -g    dollarskip.c   -o dollarskip
install -d /usr/local/bin
install -m 755 dollarskip /usr/local/bin/\$
install: cannot create regular file '/usr/local/bin/$': Permission denied
make: *** [Makefile:9: install] Error 1
$ make clean
rm -f dollarskip
$ make
cc -g    dollarskip.c   -o dollarskip
$ bmake
$ make
make: Nothing to be done for 'all'.
$ make clean
rm -f dollarskip
$ bmake clean
rm -f dollarskip
$ bmake
cc -pipe -g -g   -o dollarskip dollarskip.c
$

Copy link
Collaborator

@Itai-Nelken Itai-Nelken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be at the top/bottom of the Makefile, it tells make that the targets listed don't create anything.

.PHONY: all clean uninstall install

Copy link
Collaborator

@Itai-Nelken Itai-Nelken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Itai-Nelken
Copy link
Collaborator

@Vaelatern I think you need to sign the commits for us to be able to merge, is that correct @CleanMachine1?

This Makefile both follows convention better, and uses sane defaults

For example, make has default rules for building.

All projects, unless they are certain, should use them. So this does.

This also adds `install` without falling into the `-D` portability trap.

This program should never be accepted as a package to any Linux
distribution.
@CleanMachine1
Copy link
Owner

I dont remember turning that rule on. I'll merge as administrator and also disable that rule

@CleanMachine1
Copy link
Owner

@Vaelatern Its signed however you need to upload the key here

@CleanMachine1 CleanMachine1 merged commit 1642e2e into CleanMachine1:master Nov 21, 2021
@CleanMachine1
Copy link
Owner

Thanks for contributing!

Itai-Nelken added a commit to Itai-Nelken/DollarSkip that referenced this pull request Jan 6, 2022
* Better makefile (CleanMachine1#21)

* fix github actions (CleanMachine1#24)

* Cleaned README (CleanMachine1#25)

* Added version reference in README

* PKGBUILD for Arch users (CleanMachine1#26)

* README

* Added version refernace in README

* Added Arch PKGBUILD file

* .gitignore to remove files made with makepkg

* Added PKGBUILD install for arch in README

* Other

* added make to depends

* Update PKGBUILD

Co-authored-by: Itai Nelken <70802936+Itai-Nelken@users.noreply.github.com>

* added wildcard for .gitignore

Co-authored-by: Itai Nelken <70802936+Itai-Nelken@users.noreply.github.com>

* Added build passing badge

Co-authored-by: Itai Nelken <70802936+Itai-Nelken@users.noreply.github.com>

* makefile: adopted `PREFIX` (CleanMachine1#30)

* Changed PKGBUILD sha256sums (CleanMachine1#31)

* Skipping sums (CleanMachine1#32)

* Changed PKGBUILD sha256sums

* SKIPED SHA256

* minor error

* Added PKGBUILD sums (CleanMachine1#33)

* Add comments (CleanMachine1#23)

* Add comments that explain what the code does

Signed-off-by: Itai-Nelken <itainelken@gmail.com>

* Update dollarskip.c

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>

* Add space before comment text

Signed-off-by: Itai-Nelken <itainelken@gmail.com>

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>

* Add yay to README (CleanMachine1#39)

* Add yayto install

* Add more info

* README: grammatical error fix (CleanMachine1#40)

* Repair makefile (CleanMachine1#41)

This Makefile both follows convention better, and uses sane defaults

For example, make has default rules for building.

All projects, unless they are certain, should use them. So this does.

This also adds `install` without falling into the `-D` portability trap.

This program should never be accepted as a package to any Linux
distribution.

* Fix workflow (CleanMachine1#42)

* rewrite

Signed-off-by: Itai-Nelken <itainelken@gmail.com>

* Check that there is enough space for everything, not just arguments

Signed-off-by: Itai-Nelken <itainelken@gmail.com>

* Update dollarskip.c

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>

* fix comment

* Update dollarskip.c

* Update dollarskip.c

* Update dollarskip.c

* Fix PKGBUILD and update it to latest release (CleanMachine1#44)

* Fix PKGBUILD and update it to latest release

Signed-off-by: Itai-Nelken <itainelken@gmail.com>

* The actual fix

Signed-off-by: Itai-Nelken <itainelken@gmail.com>

* Update PKGBUILD

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Co-authored-by: pixel <35269695+pixelcmtd@users.noreply.github.com>
Co-authored-by: Toyam Cox <aviator45003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants