Add comments #23
Merged
Add comments #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itai-Nelken <itainelken@gmail.com>
Owner
|
Could you add spaces between // so instead of //hello world |
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Signed-off-by: Itai-Nelken <itainelken@gmail.com>
CleanMachine1
approved these changes
Aug 8, 2021
Owner
CleanMachine1
left a comment
CleanMachine1
left a comment
There was a problem hiding this comment.
Give another 24 hours, then I will probably review again then feel free to merge this.
Itai-Nelken
added a commit
to Itai-Nelken/DollarSkip
that referenced
this pull request
Jan 6, 2022
* Better makefile (CleanMachine1#21) * fix github actions (CleanMachine1#24) * Cleaned README (CleanMachine1#25) * Added version reference in README * PKGBUILD for Arch users (CleanMachine1#26) * README * Added version refernace in README * Added Arch PKGBUILD file * .gitignore to remove files made with makepkg * Added PKGBUILD install for arch in README * Other * added make to depends * Update PKGBUILD Co-authored-by: Itai Nelken <70802936+Itai-Nelken@users.noreply.github.com> * added wildcard for .gitignore Co-authored-by: Itai Nelken <70802936+Itai-Nelken@users.noreply.github.com> * Added build passing badge Co-authored-by: Itai Nelken <70802936+Itai-Nelken@users.noreply.github.com> * makefile: adopted `PREFIX` (CleanMachine1#30) * Changed PKGBUILD sha256sums (CleanMachine1#31) * Skipping sums (CleanMachine1#32) * Changed PKGBUILD sha256sums * SKIPED SHA256 * minor error * Added PKGBUILD sums (CleanMachine1#33) * Add comments (CleanMachine1#23) * Add comments that explain what the code does Signed-off-by: Itai-Nelken <itainelken@gmail.com> * Update dollarskip.c Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> * Add space before comment text Signed-off-by: Itai-Nelken <itainelken@gmail.com> Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> * Add yay to README (CleanMachine1#39) * Add yayto install * Add more info * README: grammatical error fix (CleanMachine1#40) * Repair makefile (CleanMachine1#41) This Makefile both follows convention better, and uses sane defaults For example, make has default rules for building. All projects, unless they are certain, should use them. So this does. This also adds `install` without falling into the `-D` portability trap. This program should never be accepted as a package to any Linux distribution. * Fix workflow (CleanMachine1#42) * rewrite Signed-off-by: Itai-Nelken <itainelken@gmail.com> * Check that there is enough space for everything, not just arguments Signed-off-by: Itai-Nelken <itainelken@gmail.com> * Update dollarskip.c Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> * fix comment * Update dollarskip.c * Update dollarskip.c * Update dollarskip.c * Fix PKGBUILD and update it to latest release (CleanMachine1#44) * Fix PKGBUILD and update it to latest release Signed-off-by: Itai-Nelken <itainelken@gmail.com> * The actual fix Signed-off-by: Itai-Nelken <itainelken@gmail.com> * Update PKGBUILD Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com> Co-authored-by: pixel <35269695+pixelcmtd@users.noreply.github.com> Co-authored-by: Toyam Cox <aviator45003@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.