Fix using through SwiftPM #8
Conversation
Xcode generates these spontaneously.
The CrashReportWindowController wouldn't find its nib when CrashReporter was loaded through SwiftPM. - Bump package tools version (see: https://developer.apple.com/documentation/xcode/bundling-resources-with-a-swift-package) - Disable module auto discovery in nib - Change window controller initialization code to manually load the nib - Add CrashReporterBundle to expose correct current bundle
DivineDominion
left a comment
DivineDominion
left a comment
There was a problem hiding this comment.
Code looks good, thank you!
Could you replace tabs with 4 spaces real quick for consistency? I believe it's required to use swift format, now shipping with Xcode 16+, in the future, but that's not going to run on auto-save. Ugh. Sorry for the nit I'm picking here :(
|
|
||
| // Replicate default init behavior | ||
| window?.delegate = self | ||
| windowDidLoad() |
There was a problem hiding this comment.
I'm fine with inlining the function here, too, now that we are doing everything manually anyway. Less indirection, and all properties are set by this point anyway.
|
|
|
No problem—I usually try to match indentation style, but forgot. I applied swift-format, which changed more than indentation. Do tell if that's not what you had in mind! |
|
Thanks! The noise of |
2 participants
The CrashReportWindowController wouldn't find its nib when CrashReporter was loaded through SwiftPM.