This repository was archived by the owner on Nov 15, 2021. It is now read-only.
refactor-prompt #805
Merged
refactor-prompt #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP make prompt commands plugin based Signed-off-by: Guillaume George <lysandergc@gmail.com> * Merge ixje:refactor-prompt Signed-off-by: Guillaume George <lysandergc@gmail.com> * Handle help detection in prompt.py Signed-off-by: Guillaume George <lysandergc@gmail.com> * Use CommandBase for subcommands to be able to have N levels of commands. Signed-off-by: Guillaume George <lysandergc@gmail.com> * Move "create wallet" command into "wallet" Signed-off-by: Guillaume George <lysandergc@gmail.com>
…andDesc.command as an id. (#725) Signed-off-by: Guillaume George <lysandergc@gmail.com>
* Improve CommandBase.register_sub_command to use the subcommand's CommandDesc.command as an id. Signed-off-by: Guillaume George <lysandergc@gmail.com> * Fix exception when a command was used without arguments (for example "wallet") Signed-off-by: Guillaume George <lysandergc@gmail.com>
* Update description and clarify debug logs * Make return's explicit, clarify multi-sig help message * cleanup prompt * remove colour from initial help, sort commands alphabetically, cleanup descriptions * fix linting * process feedback
* Improve CommandBase.register_sub_command to use the subcommand's CommandDesc.command as an id. Signed-off-by: Guillaume George <lysandergc@gmail.com> * Fix CommandWalletCreateAddress missing parameter desc Signed-off-by: Guillaume George <lysandergc@gmail.com> * Fix missing words for autocompletion Signed-off-by: Guillaume George <lysandergc@gmail.com>
…eate_addr (#733) * Add missing tests for wallet create, verbose and create_addr Signed-off-by: Guillaume George <lysandergc@gmail.com> * fix reviews Signed-off-by: Guillaume George <lysandergc@gmail.com>
This would lead to some problems when the blockchain is reset but the NodeLeader instance members are not. Transactions were still considered as known. Some members were not reset in NodeLeader.Setup() Also removed unsued member NodeLeader.MissionsGlobal Signed-off-by: Guillaume George <lysandergc@gmail.com>
Signed-off-by: Guillaume George <lysandergc@gmail.com>
…ython into refactor-prompt * 'refactor-prompt' of https://github.com/CityOfZion/neo-python: [refactor-prompt] Implement CommandWalletClaimGas (#740) [refactor prompt] Add support for show method group (pt 2) (#741) remove deprecated migrate command (#748)
* Migrate command: wallet delete_addr Signed-off-by: Guillaume George <lysandergc@gmail.com> * UserWallet.DeleteAddress now returns False on error + proper handling of invalid addresses in CommandWalletDeleteAddress Signed-off-by: Guillaume George <lysandergc@gmail.com>
Signed-off-by: Guillaume George <lysandergc@gmail.com>
…ython into refactor-prompt * 'refactor-prompt' of https://github.com/CityOfZion/neo-python: Migrate command: wallet alias (#753) [refactor-prompt] Migrate command: wallet delete_addr (#752) [refactor-prompt] Add wallet token base + delete (#757)
* remove deprecated migrate command * Add wallet token send * Update requirements and use isValidPublicAddress from new neo-python-core version * - fix send token description - process feedback * fix doc string typo
* Add wallet token history * process feedback * fix broken test after base branch merge
* add wallet export commands * Fix export nep2 to ask for passwords to prevent pw leaking to logs * process feedback
* add import multsig address * remove obsolete function
* migrate command: wallet unspent Signed-off-by: Guillaume George <lysandergc@gmail.com> * wallet unspent - add tests Signed-off-by: Guillaume George <lysandergc@gmail.com> * fix arguments names and missing doc Signed-off-by: Guillaume George <lysandergc@gmail.com> * Handle review: add feedback when there is no asset matching the arguments + use neocore.Utils.isValidPublicAddress Signed-off-by: Guillaume George <lysandergc@gmail.com>
* add debugstorage command (and fix auto save linting error) * correct comments
* add sc deploy (previously known as; import contract) * process feedback
* add sc invoke (previously known as testinvoke) * process feedback
* remove password bypass * remove unused import
* update global readme * update docs * process feedback * update show contract output
* re-store theming support * fix comment
* Update Send.py * Update test_send_command.py * rename test_send_command.py as test_send_commands.py
…ython into refactor-prompt * 'refactor-prompt' of https://github.com/CityOfZion/neo-python: (37 commits) fix calculation of change value when using alternating asset inputs (#803) [refactor-prompt] Fix #800 (#802) [refactor-prompt] Improve send & sendmany (third try) (#799) Fix send/sendmany default wallet source address for tx (#796) fix prompt printer for lists and other possible objects (#795) clarify insufficient funds error message due to not enough unspent outputs (#793) improve wallet usage help (#794) [refactor-prompt] restore theming support (#788) [refactor-prompt] update docs (#789) [refactor-prompt] enforce pw prompt send (#791) fix exception in help if command has no params (#792) add wallet password checking before exporting (#790) streamline parameter descriptions (#787) [refactor-prompt] add sc invoke (#786) [refactor-prompt] add sc deploy (#785) [refactor-prompt] add debugstorage command (#784) [refactor-prompt] cleanup 2 (#783) [refactor-prompt] add support for the sc group including build, build_run, and load_run (#779) split prompt wallet into multiple files (#782) Add wallet import contract_addr (#777) ...
…into refactor-prompt
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a repost of #804 via my personal github repo. #804 seems to have build issues while this PR continuously builds fine.
What current issue(s) does this address, or what feature is it adding?
Address #623
Huge thanks @jseagrave21 and @LysanderGG
How did you solve this problem?
see #623
How did you make sure your solution works?
make test
Are there any special changes in the code that we should be aware of?
I've chosen to not include #731 at this time. Mostly because I want this hard work in the development branch such that people can test it for a couple of days before we do a new release. The module loading part can be addresses at a later point. For that I want to spent a little bit more time to see how we can also support targeted loading (meaning; load the custom cmd into a specific existing sub group)
Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)