Skip to content
This repository was archived by the owner on Nov 15, 2021. It is now read-only.

Prompt cleanup #730

Merged
merged 6 commits into from
Nov 29, 2018
Merged

Prompt cleanup #730

merged 6 commits into from
Nov 29, 2018

Conversation

ixje
Copy link
Member

@ixje ixje commented Nov 28, 2018

What current issue(s) does this address, or what feature is it adding?

  • clean up command descriptions
  • apply alphabetic ordering of help (sub)command(s). Note: this does not apply to parameters. Just (sub)commands.
  • remove colour from help. We had all help except the root level in black. Now also root level
  • clean up prompt.py by removing unused imports and functions that have been or are about to be migrated to their own commands.

How did you solve this problem?
mostly see above

How did you make sure your solution works?
manual observation

Are there any special changes in the code that we should be aware of?
@LysanderGG FYI; I had to removed your set comprehension for help printing because it would throw away my key sorting.

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

@coveralls
Copy link

coveralls commented Nov 28, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 83.548% when pulling 35b2e70 on ixje:prompt-cleanup into 4519bb1 on CityOfZion:refactor-prompt.

@jseagrave21
Copy link
Contributor

This looks great. The only thing I can see is that during the refactoring process, it was nice to have the old help and command structure available as a ready-reference. However, we can use the development branch online just as easily.

jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Nov 28, 2018
@jseagrave21
Update Send.py
babc950 
- update to match CityOfZion#730
LysanderGG
LysanderGG reviewed Nov 29, 2018
View reviewed changes
Copy link
Contributor

@LysanderGG LysanderGG left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was nice to have the old help and command structure available as a ready-reference

👍
I think it would be easier to still have it here and remove the ones that we migrated already.

@LysanderGG FYI; I had to removed your set comprehension for help printing because it would throw away my key sorting.

👌

LysanderGG
LysanderGG reviewed Nov 29, 2018
View reviewed changes
@ixje ixje merged commit d21222f into CityOfZion:refactor-prompt Nov 29, 2018
@ixje ixje deleted the prompt-cleanup branch November 29, 2018 07:40
ixje added a commit that referenced this pull request Jan 10, 2019
@ixje
refactor-prompt (#805)
75a5f74 
* Add the bases for making prompt commands plugin based (#720)

* WIP make prompt commands plugin based

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Merge ixje:refactor-prompt

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Handle help detection in prompt.py

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Use CommandBase for subcommands to be able to have N levels of commands.

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Move "create wallet" command into "wallet"

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Improve CommandBase.register_sub_command to use the subcommand's CommandDesc.command as an id. (#725)

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Fix 1 word commands (#727)

* Improve CommandBase.register_sub_command to use the subcommand's CommandDesc.command as an id.

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Fix exception when a command was used without arguments (for example "wallet")

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Add support for `wallet` `send`, `sendmany`, `sign`, `open`, and `close` (#726)

* Prompt cleanup (#730)

* Update description and clarify debug logs

* Make return's explicit, clarify multi-sig help message

* cleanup prompt

* remove colour from initial help, sort commands alphabetically, cleanup descriptions

* fix linting

* process feedback

* [refactor-prompt] Prompt fixes (#732)

* Improve CommandBase.register_sub_command to use the subcommand's CommandDesc.command as an id.

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Fix CommandWalletCreateAddress missing parameter desc

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Fix missing words for autocompletion

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* [refactor-prompt] Add missing tests for wallet create, verbose and create_addr (#733)

* Add missing tests for wallet create, verbose and create_addr

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* fix reviews

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* [refactor prompt] Add support for search method group (#739)

* [refactor prompt] Add support for show method group (pt 1) (#738)

* Fix NodeLeader was not reset between test cases. (#742)

This would lead to some problems when the blockchain is reset but the NodeLeader instance members are not.
Transactions were still considered as known.

Some members were not reset in NodeLeader.Setup()
Also removed unsued member NodeLeader.MissionsGlobal

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Migrate command: wallet rebuild (#747)

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* remove deprecated migrate command

* remove deprecated migrate command (#748)

* [refactor prompt] Add support for show method group (pt 2) (#741)

* [refactor-prompt] Implement CommandWalletClaimGas (#740)

* [refactor-prompt] Add wallet token base + delete (#757)

* [refactor-prompt] Migrate command: wallet delete_addr (#752)

* Migrate command: wallet delete_addr

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* UserWallet.DeleteAddress now returns False on error + proper handling of invalid addresses in CommandWalletDeleteAddress

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Migrate command: wallet alias (#753)

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* [refactor-prompt] Add wallet token send (#758)

* remove deprecated migrate command

* Add wallet token send

* Update requirements and use isValidPublicAddress from new neo-python-core version

* - fix send token description
- process feedback

* fix doc string typo

* [refactor prompt] Add support for config group pt1 (#759)

* add wallet import nep2/wif (#765)

* [refactor-prompt] add wallet token history (#763)

* Add wallet token history

* process feedback

* fix broken test after base branch merge

* [refactor-prompt] add wallet export commands (#764)

* add wallet export commands

* Fix export nep2 to ask for passwords to prevent pw leaking to logs

* process feedback

* [refactor-prompt] add wallet import watchaddr (#766)

* [refactor-prompt] add token sendfrom (#761)

* [refactor-prompt] add import multisig_addr (#767)

* add import multsig address

* remove obsolete function

* [refactor-prompt] Migrate command: wallet unspent (#760)

* migrate command: wallet unspent

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* wallet unspent - add tests

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* fix arguments names and missing doc

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Handle review: add feedback when there is no asset matching the arguments + use neocore.Utils.isValidPublicAddress

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* [refactor prompt] Add support for config maxpeers (#762)

* add token approve and token allowance (#769)

* add config nep8 (#771)

* [refactor-prompt] Migrate command: wallet split (#770)

* Migrate command wallet split

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Fix some comments

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Fix command desc + remove print() calls committed by mistake

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Add tests for CommandWalletSplit

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Review: test_wallet_split use string arguments instead of ints

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Handle Reviews - handle negative fees, improve error messages

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* add token mint (#773)

* [refactor prompt] Fix `search asset` and `search contract` (#774)

* Update prompt.py

- add CommandShow and CommandSearch to prompt

* Update prompt.py

revert changes

* Update Search.py

- update `search contract` and `search asset` per #623 (comment)

* Update test_search_commands.py

- add tests in case no search parameter is provided

* add token register (#775)

* [refactor-prompt] Migrate command: wallet import token (#772)

* test_wallet_commands.py: Move tests of non commands at the end

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Add wallet import token

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Review: return None implicitly where possible

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Add a few tests for SplitUnspentCoin()

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* CommandWalletImportToken - Handle review: better validation of contract_hash

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* Add wallet import contract_addr (#777)

Signed-off-by: Guillaume George <lysandergc@gmail.com>

* split prompt wallet into multiple files (#782)

* [refactor-prompt] add support for the sc group including build, build_run, and load_run (#779)

* [refactor-prompt] cleanup 2 (#783)

* make base command response consistent

* fix plurality

* check input parameters before closing wallet

* streamline missing arguments response
streamline accepted boolean options for config

* process feedback

* [refactor-prompt] add debugstorage command (#784)

* add debugstorage command (and fix auto save linting error)

* correct comments

* [refactor-prompt] add sc deploy (#785)

* add sc deploy (previously known as; import contract)

* process feedback

* [refactor-prompt] add sc invoke (#786)

* add sc invoke (previously known as testinvoke)

* process feedback

* streamline parameter descriptions (#787)

* add wallet password checking before exporting (#790)

* fix exception in help if command has no params (#792)

* [refactor-prompt] enforce pw prompt send (#791)

* remove password bypass

* remove unused import

* [refactor-prompt] update docs (#789)

* update global readme

* update docs

* process feedback

* update show contract output

* [refactor-prompt] restore theming support (#788)

* re-store theming support

* fix comment

* improve wallet usage help (#794)

* clarify insufficient funds error message due to not enough unspent outputs (#793)

* fix prompt printer for lists and other possible objects (#795)

* Fix send/sendmany default wallet source address for tx (#796)

* [refactor-prompt] Improve send & sendmany (third try) (#799)

* Update Send.py

* Update test_send_command.py

* rename test_send_command.py as test_send_commands.py

* [refactor-prompt] Fix #800 (#802)

* Update prompt.py

- add CommandShow and CommandSearch to prompt

* Update prompt.py

revert changes

* Fix #800

- adds support for contracts not requiring params

* fix calculation of change value when using alternating asset inputs (#803)

* test print fix

* oops

* test again

* update makefile

* update changelog to trigger stuck build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LysanderGG LysanderGG LysanderGG left review comments

@jseagrave21 jseagrave21 jseagrave21 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ixje @coveralls @jseagrave21 @LysanderGG