Skip to content
This repository was archived by the owner on Nov 15, 2021. It is now read-only.

Fix ExtendedJsonRpcApi #662

Merged
merged 5 commits into from
Oct 11, 2018

Conversation

jseagrave21
Copy link
Contributor

@jseagrave21 jseagrave21 commented Oct 11, 2018

What current issue(s) does this address, or what feature is it adding?

  • Adds fix provided through DM with @localhuman to ExtendedJsonRpcApi so original methods are returned in addition to extended methods.

How did you solve this problem?
DM with @localhuman

How did you make sure your solution works?
manual testing

Are there any special changes in the code that we should be aware of?
No

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
- add fix provided by @localhuman so original methods are returned as well as extended methods
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.042% when pulling a9233ea on jseagrave21:fix-ExtendedJsonRpcApi into 173342a on CityOfZion:development.

@localhuman
Copy link
Collaborator

👍

@localhuman localhuman merged commit d9dce0b into CityOfZion:development Oct 11, 2018
@jseagrave21 jseagrave21 deleted the fix-ExtendedJsonRpcApi branch October 11, 2018 15:46
jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Oct 13, 2018
* Update ExtendedJsonRpcApi.py

- add fix provided by @localhuman so original methods are returned as well as extended methods
jseagrave21 added a commit to jseagrave21/neo-python that referenced this pull request Oct 18, 2018
* Fix ExtendedJsonRpcApi (CityOfZion#662)

* Update ExtendedJsonRpcApi.py

- add fix provided by @localhuman so original methods are returned as well as extended methods

* Mute expected test stacktrace and clearly identify why an exception is thrown. (CityOfZion#663)

* Add guideline for adding tests to the neo-privnet-unittest image (CityOfZion#661)

* Add the option -u (unittest-net) to prompt.py

* Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package

* Add raw transaction building examples (CityOfZion#665)

* Update neo-boa version to fix core building test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants