This repository was archived by the owner on Nov 15, 2021. It is now read-only.
Add guideline for adding tests to the neo-privnet-unittest image #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dauTT
changed the title
neo-privnet-unittest image
|
Note to self: push docker image to coz account |
ixje
suggested changes
Oct 11, 2018
There was a problem hiding this comment.
I've pushed the image to docker here: https://hub.docker.com/r/cityofzion/neo-python-privnet-unittest/tags/
Please update the links + docker pull/run instructions to match the above link. Also, please run an rst linter like rst-lint as there are linting errors in test.rst. Thanks!
|
Thanks @ixje for reviewing the PR. I have implemented your feedback. |
jseagrave21
pushed a commit
to jseagrave21/neo-python
that referenced
this pull request
Oct 13, 2018
…yOfZion#661) * Add the option -u (unittest-net) to prompt.py * Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package
jseagrave21
added a commit
to jseagrave21/neo-python
that referenced
this pull request
Oct 18, 2018
* Fix ExtendedJsonRpcApi (CityOfZion#662) * Update ExtendedJsonRpcApi.py - add fix provided by @localhuman so original methods are returned as well as extended methods * Mute expected test stacktrace and clearly identify why an exception is thrown. (CityOfZion#663) * Add guideline for adding tests to the neo-privnet-unittest image (CityOfZion#661) * Add the option -u (unittest-net) to prompt.py * Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package * Add raw transaction building examples (CityOfZion#665) * Update neo-boa version to fix core building test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
-u) to run neo-python in combination with theneo-privnet-unittestimage.How did you solve this problem?
How did you make sure your solution works?
manual testing.
running :
make docsAre there any special changes in the code that we should be aware of?
This image neo-privnet-unittest, need to be move under
COZdomain. Once this is done we need to update the link intests.rstfile.Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)