Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9249: Description override configs #502

Closed
wants to merge 1 commit into from

Conversation

dire
Copy link
Contributor

@dire dire commented Nov 28, 2023

UHF-9249

What was done

  • Show the description override field in TPR Unit edit page and view.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9249_description-override-configs
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-9249_description-override
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9249_description-override
  • Run make drush-updb drush-cim drush-cr drush-locale-update drush-cr

How to test

  • Go edit any school (e.g. https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/aleksis-kiven-peruskoulu) and check that there is a new field Override: Description.
  • Check that the field label and description is translated correctly to Finnish and Swedish, probably need to switch user's preferred UI language.
  • Add text to the description override field and save the page. Check that the field content is displayed like description normally on the unit's page.
  • Test also other TPR unit than school, e.g. this daycare unit. The field should work in them too. If the field is empty, the description coming from the TPR should be displayed as was before.
  • The description override field should be installed in other instances too, but the field should not be visible in the edit form or view display in them.
  • Check that code follows our standards.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dire
Copy link
Contributor Author

dire commented Dec 20, 2023

This one isn't needed after all as all configs are in platform config.

@dire dire closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant