Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9249: Use the new description override field #841

Merged
merged 5 commits into from
Dec 21, 2023
Merged

UHF-9249: Use the new description override field #841

merged 5 commits into from
Dec 21, 2023

Conversation

dire
Copy link
Contributor

@dire dire commented Nov 29, 2023 •
edited
Loading

UHF-9249

What was done

  • Use the description override if the TPR data for description is empty.

How to install and test

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

This was referenced Dec 5, 2023
Closed
Merged
@dire dire marked this pull request as ready for review December 7, 2023 07:24
@dire dire requested a review from Arkkimaagi December 7, 2023 07:40
@dire dire requested review from teroelonen and removed request for Arkkimaagi December 20, 2023 13:06
teroelonen
teroelonen approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean and nice, great work here too 🦖

@dire dire merged commit 42da489 into main Dec 21, 2023
1 check passed
@dire dire deleted the UHF-9249_description-override branch December 21, 2023 06:46
This was referenced Dec 21, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dire @teroelonen