New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8707: Fixed other languages bugs in latest news component #420

Merged

dire merged 2 commits into dev from UHF-8707_other-languages-bugs

Aug 25, 2023

Contributor

dire commented Aug 18, 2023 •

edited by Arkkimaagi

Loading

UHF-8707

The "See all news" button in latest news component didn't have language attribute fallback on other languages.

What was done

Added the missing fallback attributes.

How to install

Make sure your etusivu instance is up and running on correct branch.
- git checkout UHF-8707_other-languages-bugs
- make fresh
Run make drush-cr

How to test

Open https://helfi-etusivu.docker.so/uk/hromada-helsinki-pidtrymuye-bizhentsiv-z-ukrayiny-ta-ukrayintsiv-yaki-zalyshylysya-v-finlyandiyi#latest-news and check that the "See all news" button has the lang="en" dir="ltr" attributes.
The other change (in the paragraph--front-page-latest-news.html.twig) is a helper for the other PR.
Check that code follows our standards

Designers review

This PR does not need designers review

Other PRs

Link to other PR


          UHF-8707: Added lang and dir fallbacks to the see more button in late…

db9823c

…st news listing.

dire mentioned this pull request

UHF-8707 other languages bugs City-of-Helsinki/drupal-hdbt#750

Merged

5 tasks

dire marked this pull request as draft

August 18, 2023 06:59


          UHF-8707: Added a helper variable.

2c872ab

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

dire marked this pull request as ready for review

August 18, 2023 07:29

Arkkimaagi approved these changes

View reviewed changes

Contributor

Arkkimaagi left a comment

This code looks good and can be merged. Good job!

dire merged commit b178138 into dev

3 checks passed

dire deleted the UHF-8707_other-languages-bugs branch

August 25, 2023 07:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet