UHF-8707 other languages bugs #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Arkkimaagi
requested changes
Aug 24, 2023
templates/component/accordion.twig
Outdated
| @@ -28,7 +28,7 @@ | |||
| {{ content|default('Missing content'|t) }} | |||
|
|
|||
| <button type="button" class="accordion-item__button accordion-item__button--close" aria-controls="{{ controlled_content_id }}" aria-labelledby="{{ close_button_labelled_by_id }}"> | |||
| <span class="is-hidden" id="{{ close_button_labelled_by_id }}">{{ 'Close element: '|t({}, {'context': 'The helper text for close accordion visibility button'}) }}{{ heading|default('Missing heading'|t) }}</span> | |||
| <span class="is-hidden" id="{{ close_button_labelled_by_id }}"><span {{ alternative_language ? create_attribute(({ 'lang': lang_attributes.fallback_lang })) }}>{{ 'Close element: '|t({}, {'context': 'The helper text for close accordion visibility button'}) }}</span>{{ heading|default('Missing heading'|t) }}</span> | |||
| {{ 'Close'|t({}, {'context': 'The text for close accordion visibility button'}) }} | |||
There was a problem hiding this comment.
This row is still missing a proper lang attribute. This "Close" word will be read with rally-ukrainian or similar.
There was a problem hiding this comment.
Wrapped this with a <span lang="en" dir="ltr">.
templates/component/accordion.twig
Outdated
| @@ -28,7 +28,7 @@ | |||
| {{ content|default('Missing content'|t) }} | |||
|
|
|||
| <button type="button" class="accordion-item__button accordion-item__button--close" aria-controls="{{ controlled_content_id }}" aria-labelledby="{{ close_button_labelled_by_id }}"> | |||
| <span class="is-hidden" id="{{ close_button_labelled_by_id }}">{{ 'Close element: '|t({}, {'context': 'The helper text for close accordion visibility button'}) }}{{ heading|default('Missing heading'|t) }}</span> | |||
| <span class="is-hidden" id="{{ close_button_labelled_by_id }}"><span {{ alternative_language ? create_attribute(({ 'lang': lang_attributes.fallback_lang })) }}>{{ 'Close element: '|t({}, {'context': 'The helper text for close accordion visibility button'}) }}</span>{{ heading|default('Missing heading'|t) }}</span> | |||
There was a problem hiding this comment.
This row is missing dir-attribute for the fallback language. If the page is for example in arabic, this code could fail.
There was a problem hiding this comment.
Added the dir-attribute.
templates/misc/component.twig
Outdated
| @@ -56,7 +56,7 @@ Example usage: | |||
|
|
|||
| <div class="component__container"> | |||
| {% if hasTitle %} | |||
| <{{ component_title_level|default('h2') }} class="component__title"> | |||
| <{{ component_title_level|default('h2') }} class="component__title" {{ use_component_title_lang_fallback ? create_attribute(({ 'lang': lang_attributes.fallback_lang })) }}> | |||
There was a problem hiding this comment.
This row is missing dir-attribute for the fallback language. If the page is for example in arabic, this code could fail.
There was a problem hiding this comment.
Added the dir attribute.
Arkkimaagi
approved these changes
Aug 25, 2023
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-8707
What was done
How to install
git pull origin devmake freshcomposer require drupal/hdbt:dev-UHF-8707_other-languages-bugsmake drush-crHow to test
<span lang="en">.lang="en".Designers review
Other PRs