Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CircleCI IP Ranges #243

Merged
merged 4 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/jobs/continue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,15 @@ parameters:
description: The executor to use for this job. By default, this will use the "default" executor provided by this orb.
type: executor
default: default
circleci_ip_ranges:
description: Enables jobs to go through a set of well-defined IP address ranges.
type: boolean
default: false

executor: << parameters.executor >>

circleci_ip_ranges: << parameters.circleci_ip_ranges >>

steps:
- when:
condition: <<parameters.checkout>>
Expand Down
6 changes: 6 additions & 0 deletions src/jobs/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,15 @@ parameters:
description: The executor to use for this job. By default, this will use the "python" executor provided by this orb.
type: executor
default: python
circleci_ip_ranges:
description: Enables jobs to go through a set of well-defined IP address ranges.
type: boolean
default: false

executor: << parameters.executor >>

circleci_ip_ranges: << parameters.circleci_ip_ranges >>

steps:
- when:
condition: <<parameters.checkout>>
Expand Down
6 changes: 6 additions & 0 deletions src/jobs/pack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,15 @@ parameters:
You can use "org_id" instead if you prefer.
type: string
default: ""
circleci_ip_ranges:
description: Enables jobs to go through a set of well-defined IP address ranges.
type: boolean
default: false

executor: << parameters.executor >>

circleci_ip_ranges: << parameters.circleci_ip_ranges >>

steps:
- when:
condition: <<parameters.checkout>>
Expand Down
6 changes: 6 additions & 0 deletions src/jobs/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ parameters:
description: The executor to use for this job. By default, this will use the "default" executor provided by this orb.
type: executor
default: default
circleci_ip_ranges:
description: Enables jobs to go through a set of well-defined IP address ranges.
type: boolean
default: false
attach_workspace:
type: boolean
default: true
Expand All @@ -95,6 +99,8 @@ parameters:

executor: << parameters.executor >>

circleci_ip_ranges: << parameters.circleci_ip_ranges >>

steps:
- when:
condition: <<parameters.attach_workspace>>
Expand Down
6 changes: 6 additions & 0 deletions src/jobs/review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,15 @@ parameters:
description: The executor to use for this job. By default, this will use the "python" executor provided by this orb.
type: executor
default: python
circleci_ip_ranges:
description: Enables jobs to go through a set of well-defined IP address ranges.
type: boolean
default: false

executor: << parameters.executor >>

circleci_ip_ranges: << parameters.circleci_ip_ranges >>

steps:
- when:
condition: <<parameters.checkout>>
Expand Down
2 changes: 1 addition & 1 deletion src/scripts/publish.sh
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,4 @@ function orbPublish() {
ORB_RELEASE_VERSION=""
ORB_VAL_ORB_PUB_TOKEN=${!ORB_VAL_ORB_PUB_TOKEN}
mkdir -p /tmp/orb_dev_kit/
orbPublish
orbPublish
2 changes: 1 addition & 1 deletion src/scripts/review.bats
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ setup() {
fi
}

@test "RC004: Usage example names shoud be descriptive." {
@test "RC004: Usage example names should be descriptive." {
if [[ "${SKIPPED_REVIEW_CHECKS[*]}" =~ "RC004" ]]; then
skip
fi
Expand Down