Support CircleCI IP Ranges #243

david-montano-circleci · 2024-10-31T21:45:58Z

See: #241
This PR was created after extending the user's PR to actually use the new parameters in the different orb jobs.
I tested:

without specifying the flag: the false parameter is used and it does not break existing jobs. Jobs are run in random public IPs.
specifying the flag as false: it does not break existing jobs. Jobs are run in random public IPs.
specifying the flag as true: it does not break existing jobs unless the user has not a circleci subscription. Jobs are run in public IPs listed in this document.

Signed-off-by: Adam Harvey <adam.harvey@okta.com>

src/executors/default.yml

src/executors/python.yml

orb-publisher · 2024-10-31T21:59:07Z

adamharvey-okta and others added 3 commits October 15, 2024 00:07

feat: Support CircleCI IP Ranges

615da26

Signed-off-by: Adam Harvey <adam.harvey@okta.com>

chore: Fix typo

c734642

fix: use new parameter in job definitions

bbab5c9

david-montano-circleci requested a review from marboledacci October 31, 2024 21:45

david-montano-circleci self-assigned this Oct 31, 2024

david-montano-circleci requested a review from a team as a code owner October 31, 2024 21:45

david-montano-circleci mentioned this pull request Oct 31, 2024

feat: Support CircleCI IP Ranges #241

Closed

marboledacci reviewed Oct 31, 2024

View reviewed changes

src/executors/default.yml Outdated Show resolved Hide resolved

src/executors/python.yml Outdated Show resolved Hide resolved

fix: removing uneeded parameters from the executors

0f4ddd4

david-montano-circleci requested a review from marboledacci October 31, 2024 21:57

marboledacci approved these changes Oct 31, 2024

View reviewed changes

david-montano-circleci merged commit e8b6477 into master Oct 31, 2024
2 checks passed

Provide feedback