-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multipole lens profile #215
Conversation
the convergence test for some reason does not pass. I do not know why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes, and one bigger change. Could you make it so that the user passes m
as a tuple of which multipole orders they want? Then the individual functions can loop over that tuple and add the contributions from each multipole order.
Also can you add the multipole class to the test_lens_potential.py
unit test? It doesn't look like its in there although I thought I saw you running that test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #215 +/- ##
==========================================
+ Coverage 93.52% 93.67% +0.14%
==========================================
Files 61 63 +2
Lines 2859 2925 +66
==========================================
+ Hits 2674 2740 +66
Misses 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adresses issue #139
coauthor: @RonanLegin
Multipole Gravitational Lensing Module
This Python module, part of a larger gravitational lensing library, provides functionality to simulate and analyze multipole gravitational lensing effects. It is designed to integrate seamlessly with PyTorch and offers detailed implementations for calculating deflection angles, lensing potentials, and convergence based on multipole expansions.
Features
Gravitational Lensing Calculations: Compute deflection angles, potentials, and convergence for multipole gravitational lenses.
Documentation
Refer to the docstrings within the code for detailed usage and examples. Equations used for the calculations are referenced from "Xu et al. 2014" (https://arxiv.org/pdf/1307.4220).