Skip to content

Commit

Permalink
update variable names
Browse files Browse the repository at this point in the history
  • Loading branch information
andreasfilipp committed May 29, 2024
1 parent 3936074 commit 677244a
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 10 deletions.
29 changes: 20 additions & 9 deletions src/caustics/lenses/multipole.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,26 @@ class Multipole(ThinLens):
def __init__(
self,
cosmology: CosmologyType,
z_l: Optional[Union[Tensor, float]] = None,
x0: Optional[Union[Tensor, float]] = None,
y0: Optional[Union[Tensor, float]] = None,
a_m: Optional[Union[Tensor, float]] = None,
phi_m: Optional[Union[Tensor, float]] = None,
m: Optional[Union[Tensor, int]] = None,
s: float = 0.0,
name: Optional[str] = None,
z_l: ZLType = None,

x0: Annotated[
Optional[Union[Tensor, float]], "The x-coordinate of the lens center", True
] = None,
y0: Annotated[
Optional[Union[Tensor, float]], "The y-coordinate of the lens center", True
] = None,
a_m: Annotated[
Optional[Union[Tensor, float]], "The amplitude of the multipole", True
] = None, # TODO change to true axis ratio
phi_m: Annotated[
Optional[Union[Tensor, float]],
"The orientation angle of the multipole",
True,
] = None,
m: Annotated[
Optional[Union[Tensor, float]], "The Multiploe moment m", True
] = None,
name: NameType = None,
):
super().__init__(cosmology, z_l, name=name)

Expand All @@ -63,7 +75,6 @@ def __init__(
if m < 3:
raise ValueError("Multipole order must be greater than 2")
self.add_param("m", m)
self.s = s

@unpack
def reduced_deflection_angle(
Expand Down
2 changes: 1 addition & 1 deletion src/caustics/models/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def _get_kwargs_field_definitions(
if k != "name":
anno = v.annotation
dtype = anno.__origin__
cls_param = ClassParam(*anno.__metadata__)
cls_param = ClassParam(*anno.__metadata__) # gooooo
if cls_param.isParam:
kwargs_field_definitions[PARAMS][k] = (
dtype,
Expand Down

0 comments on commit 677244a

Please sign in to comment.