Feature/2124 notification bar #2167

crossan007 · 2017-03-25T17:26:36Z

closes #2124.

Notifications are retreived from a JSON file:
http://demo.churchcrm.io/notifications.json

Displayed if the target version matches:

Apply fixes from StyleCI

…urchCRM/CRM into feature/2124-notification-bar

DawoudIO · 2017-03-25T20:04:15Z

why Master?

DawoudIO · 2017-03-25T20:05:00Z

src/ChurchCRM/Service/NotificationService.php

+     */
+    try
+    {
+      $_SESSION['SystemNotifications'] = json_decode(file_get_contents("http://demo.churchcrm.io/notifications.json"));


we should have the URL in our config somewhere... i know it is static but it might change... or create a var for it.

DawoudIO · 2017-03-25T20:05:28Z

src/ChurchCRM/Service/NotificationService.php

+      $_SESSION['SystemNotifications']->expires = new \DateTime();
+      $_SESSION['SystemNotifications']->expires->add(new \DateInterval("PT".$_SESSION['SystemNotifications']->TTL."S"));
+    } catch (Exception $ex) {
+      //a failure here should never prevent the page from loading.  


lets still log it...

Let's do this with #2062

DawoudIO · 2017-03-25T20:06:40Z

src/ChurchCRM/Service/NotificationService.php

+    }
+  }
+
+  public static function testActiveNotifications()


hasActiveNotifications

DawoudIO · 2017-03-25T20:07:44Z

src/Include/Header.php

@@ -62,6 +62,9 @@
 </head>

 <body class="hold-transition <?= $_SESSION['sStyle'] ?> sidebar-mini">
+<?php
+  Header_system_notifications();


not sure i like this as it is only used once, no need for a funcation

DawoudIO

is it that every time you login you see it... i think i would like a target version(s) for the notification

crossan007 · 2017-03-25T20:12:08Z

Yes - it'll always display if a notification has been set for the currently running version.

Notifications are version-targeted already ;-) take a look at http://demo.churchcrm.io/notifications.json

DawoudIO · 2017-03-26T15:26:55Z

it works as MVP, but i slows down the login page and every page.. i really think this should be just AJAX Call the service not an inline call

DawoudIO · 2017-03-26T15:28:41Z

src/ChurchCRM/dto/SystemConfig.php

@@ -160,7 +160,8 @@ private static function buildConfigs()
        "sConfirmSincerely" => new ConfigItem(1048, "sConfirmSincerely", "text", "Sincerely", gettext("Used to end a letter before Signer")),
        "googleTrackingID" => new ConfigItem(1050, "googleTrackingID", "text", "", gettext("Google Analytics Tracking Code")),
        "mailChimpApiKey" => new ConfigItem(2000, "mailChimpApiKey", "text", "", gettext("see http://kb.mailchimp.com/accounts/management/about-api-keys")),
-        "sDepositSlipType" => new ConfigItem(2001, "sDepositSlipType", "choice", "QBDT", gettext("Deposit ticket type.  QBDT - Quickbooks"), '{"Choices":["QBDT"]}')
+        "sDepositSlipType" => new ConfigItem(2001, "sDepositSlipType", "choice", "QBDT", gettext("Deposit ticket type.  QBDT - Quickbooks"), '{"Choices":["QBDT"]}'),
+        "sCloudURL" => new ConfigItem(2002, "sCloudURL", "text", "http://demo.churchcrm.io/", gettext("ChurchCRM Cloud Access URL"))


we really need private config

This will never be displayed to the user - I didn't add it to any of the sections.

DawoudIO · 2017-03-26T15:28:57Z

src/Include/Header-function.php

@@ -31,6 +31,22 @@

 use ChurchCRM\Service\SystemService;
 use ChurchCRM\dto\SystemURLs;
+use ChurchCRM\Service\NotificationService;
+
+function Header_system_notifications()


i think this should be ajax

This section is only accessing the local session variable - there is no hit to the database or web services here - only session variable.

It really shouldn't be that big of a performance hit.

* Updated Default Values * added select2 * using memeber default & select 2 for country using memeber default city/state & select 2 * Apply fixes from StyleCI (#1995) * Add Behat testing (#2010) * underp master vs develop merge * underps * start 2.6.1 (#2034) * start 2.6.1 * underp 2.6.1 upgrade. * don't include unreleased features in the changelog * 2.6.1 rev jquery photo uploader (#2035) * start 2.6.1 * underp 2.6.1 upgrade. * rev photo uploader to 1.0.10 * release window documentation (#2055) * release window doc * release window doc * cherry-pick #2061 for Master 2.6.1 * Update Config.php.example * fix broken search * rev photo uploader to 1.0.11 (#2071) * Member Count Error in Member Dashboard (#1925) * fix membercount error fix #1924 * Apply left join onn family wher join with person to get the members without family accounted. * Also added Links to Family Roles section on membersdashboard. * Changes to use SystemConfig using SystemConfig::getValue('sDirRoleChild') * PersonView, FamilyView ui changes #1863 (#2026) * PersonView, FamilyView ui changes #1863 closes #1863 changed overlay, added view photo button. added modal for displaying larger photo, displaying view photo button, using code from Initials.js if photo exists. * addressing review comments * UI Cleanup/bugs closes #2084 #2112 * UI Improvments closes #2112 * Apply fixes from StyleCI (#2113) * Fix database backup (#2118) * closes #2099 * Apply fixes from StyleCI * using github-release-notes in the bash script renamed the npm target updated changeslog.md * updated steps and included changelog task * Cash is displayed even if 0 #1852 (#1983) * resolves #1852 * still show 0 cash if 0 cash 💯 * applied styleci patch * Remove old changelog * start 2.6.2 (#2125) * this works on ASO demo site. (#2126) * #2121-unable to create event (#2122) add document ready function around the dateranger script. fixes #2121 * start 2.6.3 (#2127) * 2.6.3 * update changelog * Update CHANGELOG.md removed dbl logs * Feature/2124 notification bar (#2167) * Working POC * Fix styles * get data from web service * Apply fixes from StyleCI * allow for differentating admin vs all user notifications * add TTL setting for notifications * don't include system notifications locally * cleanup * underp boolean call * address comments - handle exceptions correctly * fix logic if captive portal intercepts notification request * cleanup spaces * make code work again.

* Updated Default Values * added select2 * using memeber default & select 2 for country using memeber default city/state & select 2 * Apply fixes from StyleCI (#1995) * Add Behat testing (#2010) * underp master vs develop merge * underps * start 2.6.1 (#2034) * start 2.6.1 * underp 2.6.1 upgrade. * don't include unreleased features in the changelog * 2.6.1 rev jquery photo uploader (#2035) * start 2.6.1 * underp 2.6.1 upgrade. * rev photo uploader to 1.0.10 * release window documentation (#2055) * release window doc * release window doc * cherry-pick #2061 for Master 2.6.1 * Update Config.php.example * fix broken search * rev photo uploader to 1.0.11 (#2071) * Member Count Error in Member Dashboard (#1925) * fix membercount error fix #1924 * Apply left join onn family wher join with person to get the members without family accounted. * Also added Links to Family Roles section on membersdashboard. * Changes to use SystemConfig using SystemConfig::getValue('sDirRoleChild') * PersonView, FamilyView ui changes #1863 (#2026) * PersonView, FamilyView ui changes #1863 closes #1863 changed overlay, added view photo button. added modal for displaying larger photo, displaying view photo button, using code from Initials.js if photo exists. * addressing review comments * UI Cleanup/bugs closes #2084 #2112 * UI Improvments closes #2112 * Apply fixes from StyleCI (#2113) * Fix database backup (#2118) * closes #2099 * Apply fixes from StyleCI * using github-release-notes in the bash script renamed the npm target updated changeslog.md * updated steps and included changelog task * Cash is displayed even if 0 #1852 (#1983) * resolves #1852 * still show 0 cash if 0 cash 💯 * applied styleci patch * Remove old changelog * start 2.6.2 (#2125) * this works on ASO demo site. (#2126) * #2121-unable to create event (#2122) add document ready function around the dateranger script. fixes #2121 * start 2.6.3 (#2127) * 2.6.3 * update changelog * Update CHANGELOG.md removed dbl logs * Feature/2124 notification bar (#2167) * Working POC * Fix styles * get data from web service * Apply fixes from StyleCI * allow for differentating admin vs all user notifications * add TTL setting for notifications * don't include system notifications locally * cleanup * underp boolean call * address comments - handle exceptions correctly * fix logic if captive portal intercepts notification request * rev jQuery-photo-uploader (#2185) * closes #2123 (#2184) * update changelog (#2190) * update changelog * 2.6.3 * locked to 0.6.3 * locked to 0.6.3 * Update CHANGELOG.md trim down to subset of changes * Add Behat tests to TravisCI (#2011) * underp master vs develop merge * underps * add test to travis * add apache to travis. * tweaks * change path * move to script. troubleshooting. * debugging * debugging * fix path * fix path * tweaks * tweaks * underp * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * move fpm conf * tweak * tweak * tweak * tweak * fingers crossed. * fingers crossed. * fingers crossed. * debug * tweak paths * tweak config * tweak config * permissions * permissions * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * add config * tweaks * tweaks * revert login changes * change index * cleanup * underp php fpm * underp * rewrite? * rewrite? * SetHandler * use sockets * derppp * derppp * derppp sockets * derppp sockets * derppp sockets * proxy? * test? * tweaks? try again? * Important! Read the above again https://wiki.apache.org/httpd/PHP-FPM * tweak multi view * cleanup * Update Config.php * Update README.md (#2247) * added ignore question

crossan007 and others added 4 commits March 25, 2017 13:10

Working POC

e91b948

Fix styles

b2061c1

get data from web service

b63e46d

Apply fixes from StyleCI

3d48cdd

crossan007 added the In Review label Mar 25, 2017

crossan007 requested a review from DawoudIO March 25, 2017 17:26

crossan007 added this to the 2.6.3 milestone Mar 25, 2017

crossan007 added 7 commits March 25, 2017 13:28

Merge pull request #2166 from ChurchCRM/analysis-XVngLD

db614bd

Apply fixes from StyleCI

allow for differentating admin vs all user notifications

72aae06

Merge branch 'feature/2124-notification-bar' of https://github.com/Ch…

81e12fe

…urchCRM/CRM into feature/2124-notification-bar

add TTL setting for notifications

ff83218

don't include system notifications locally

76dd173

cleanup

b253402

underp boolean call

22ca17f

DawoudIO reviewed Mar 25, 2017

View reviewed changes

DawoudIO requested changes Mar 25, 2017

View reviewed changes

DawoudIO approved these changes Mar 25, 2017

View reviewed changes

crossan007 added 2 commits March 25, 2017 21:45

address comments - handle exceptions correctly

84873dd

fix logic if captive portal intercepts notification request

efec353

DawoudIO reviewed Mar 26, 2017

View reviewed changes

DawoudIO merged commit 7c4f06a into master Mar 26, 2017

DawoudIO added Documentation and removed In Review labels Mar 26, 2017

DawoudIO added the enhancement label Mar 26, 2017

crossan007 deleted the feature/2124-notification-bar branch March 26, 2017 19:02

crossan007 restored the feature/2124-notification-bar branch March 26, 2017 19:07

DawoudIO deleted the feature/2124-notification-bar branch April 2, 2017 20:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/2124 notification bar #2167

Feature/2124 notification bar #2167

crossan007 commented Mar 25, 2017

DawoudIO commented Mar 25, 2017

DawoudIO Mar 25, 2017

DawoudIO Mar 25, 2017

crossan007 Mar 26, 2017

DawoudIO Mar 25, 2017

DawoudIO Mar 25, 2017

DawoudIO left a comment

crossan007 commented Mar 25, 2017

DawoudIO commented Mar 26, 2017

DawoudIO Mar 26, 2017

crossan007 Mar 26, 2017

DawoudIO Mar 26, 2017

crossan007 Mar 26, 2017

Feature/2124 notification bar #2167

Feature/2124 notification bar #2167

Conversation

crossan007 commented Mar 25, 2017

DawoudIO commented Mar 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DawoudIO left a comment

Choose a reason for hiding this comment

crossan007 commented Mar 25, 2017

DawoudIO commented Mar 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment