Member Count Error in Member Dashboard #1925

simonkp · 2017-02-14T04:50:30Z

fix #1924

Apply left join onn family wher join with person to get the members
without family accounted.
Also added Links to Family Roles section on membersdashboard.

…CRM/master

fix #1924 * Apply left join onn family wher join with person to get the members without family accounted. * Also added Links to Family Roles section on membersdashboard.

DawoudIO · 2017-02-14T06:29:25Z

src/MembersDashboard.php

@@ -27,7 +27,7 @@
 $rsAdultsGender = RunQuery($sSQL);

 $sSQL = 'select count(*) as numb, per_Gender from person_per , family_fam
-        where fam_ID =per_fam_ID and fam_DateDeactivated is  null and per_Gender in (1,2) and per_fmr_ID not in (1,2) group by per_Gender ;';
+        where fam_ID =per_fam_ID and fam_DateDeactivated is  null and per_Gender in (1,2) and per_fmr_ID in (3) group by per_Gender ;';


these should be the sDirRoleChild

for adults, used not in sDirRoleChild

DawoudIO

lust us use the correct role ids from

"sDirRoleHead","sDirRoleSpouse","sDirRoleChild"

using SystemConfig::getValue('sDirRoleChild')

simonkp · 2017-02-14T17:06:32Z

It is not just for kids, for adults as well.
It is under the heading Gender Demographics. So i think it is ok to omit those with gender not set.

The Family Roles section will show this anyway.

DawoudIO · 2017-02-17T15:22:13Z

yep that would work.

crossan007 · 2017-02-18T17:54:21Z

This would be a good opportunity to move the dashboard service to ORM code.

I haven't yet fully thought out the transition, but let's begin.

If possible - we should create REST endpoints that are not "dashboard specific," but rather enhance our family / person endpoints so that the Dashboard can be completely client-side code querying the well-defined object endpoints.

I'm also open to implementing this fix, and tracking ORM migration in a separate PR / ticket.

DawoudIO · 2017-02-19T13:03:07Z

Let's us do the fix and track orm else where

DawoudIO · 2017-02-25T16:15:14Z

looks like this also could be fixing #1155

simonkp · 2017-02-28T18:49:47Z

I think this is good to go? any other comments?

DawoudIO · 2017-03-01T15:51:05Z

@rakess70 can you test this and let me know if it fixes your issue, if so I'll make it part of the 2.6.1 build

rakess70 · 2017-03-04T13:30:20Z

@DawoudIO I am not sure which issue you are referring to?

DawoudIO · 2017-03-05T23:28:15Z

@rakess70 sorry i thought you created the issue but it was @saulowulhynek

DawoudIO · 2017-03-05T23:28:48Z

@simonkp can you apply https://styleci.io/analyses/8wvPK4 patch

* Updated Default Values * added select2 * using memeber default & select 2 for country using memeber default city/state & select 2 * Apply fixes from StyleCI (#1995) * Add Behat testing (#2010) * underp master vs develop merge * underps * start 2.6.1 (#2034) * start 2.6.1 * underp 2.6.1 upgrade. * don't include unreleased features in the changelog * 2.6.1 rev jquery photo uploader (#2035) * start 2.6.1 * underp 2.6.1 upgrade. * rev photo uploader to 1.0.10 * release window documentation (#2055) * release window doc * release window doc * cherry-pick #2061 for Master 2.6.1 * Update Config.php.example * fix broken search * rev photo uploader to 1.0.11 (#2071) * Member Count Error in Member Dashboard (#1925) * fix membercount error fix #1924 * Apply left join onn family wher join with person to get the members without family accounted. * Also added Links to Family Roles section on membersdashboard. * Changes to use SystemConfig using SystemConfig::getValue('sDirRoleChild') * PersonView, FamilyView ui changes #1863 (#2026) * PersonView, FamilyView ui changes #1863 closes #1863 changed overlay, added view photo button. added modal for displaying larger photo, displaying view photo button, using code from Initials.js if photo exists. * addressing review comments * upgrade

* Updated Default Values * added select2 * using memeber default & select 2 for country using memeber default city/state & select 2 * Apply fixes from StyleCI (#1995) * Add Behat testing (#2010) * underp master vs develop merge * underps * start 2.6.1 (#2034) * start 2.6.1 * underp 2.6.1 upgrade. * don't include unreleased features in the changelog * 2.6.1 rev jquery photo uploader (#2035) * start 2.6.1 * underp 2.6.1 upgrade. * rev photo uploader to 1.0.10 * release window documentation (#2055) * release window doc * release window doc * cherry-pick #2061 for Master 2.6.1 * Update Config.php.example * fix broken search * rev photo uploader to 1.0.11 (#2071) * Member Count Error in Member Dashboard (#1925) * fix membercount error fix #1924 * Apply left join onn family wher join with person to get the members without family accounted. * Also added Links to Family Roles section on membersdashboard. * Changes to use SystemConfig using SystemConfig::getValue('sDirRoleChild') * PersonView, FamilyView ui changes #1863 (#2026) * PersonView, FamilyView ui changes #1863 closes #1863 changed overlay, added view photo button. added modal for displaying larger photo, displaying view photo button, using code from Initials.js if photo exists. * addressing review comments * UI Cleanup/bugs closes #2084 #2112 * UI Improvments closes #2112 * Apply fixes from StyleCI (#2113) * Fix database backup (#2118) * closes #2099 * Apply fixes from StyleCI * using github-release-notes in the bash script renamed the npm target updated changeslog.md * updated steps and included changelog task * Cash is displayed even if 0 #1852 (#1983) * resolves #1852 * still show 0 cash if 0 cash 💯 * applied styleci patch * Remove old changelog * start 2.6.2 (#2125) * this works on ASO demo site. (#2126) * #2121-unable to create event (#2122) add document ready function around the dateranger script. fixes #2121 * start 2.6.3 (#2127) * 2.6.3 * update changelog * Update CHANGELOG.md removed dbl logs * Feature/2124 notification bar (#2167) * Working POC * Fix styles * get data from web service * Apply fixes from StyleCI * allow for differentating admin vs all user notifications * add TTL setting for notifications * don't include system notifications locally * cleanup * underp boolean call * address comments - handle exceptions correctly * fix logic if captive portal intercepts notification request * cleanup spaces * make code work again.

* Updated Default Values * added select2 * using memeber default & select 2 for country using memeber default city/state & select 2 * Apply fixes from StyleCI (#1995) * Add Behat testing (#2010) * underp master vs develop merge * underps * start 2.6.1 (#2034) * start 2.6.1 * underp 2.6.1 upgrade. * don't include unreleased features in the changelog * 2.6.1 rev jquery photo uploader (#2035) * start 2.6.1 * underp 2.6.1 upgrade. * rev photo uploader to 1.0.10 * release window documentation (#2055) * release window doc * release window doc * cherry-pick #2061 for Master 2.6.1 * Update Config.php.example * fix broken search * rev photo uploader to 1.0.11 (#2071) * Member Count Error in Member Dashboard (#1925) * fix membercount error fix #1924 * Apply left join onn family wher join with person to get the members without family accounted. * Also added Links to Family Roles section on membersdashboard. * Changes to use SystemConfig using SystemConfig::getValue('sDirRoleChild') * PersonView, FamilyView ui changes #1863 (#2026) * PersonView, FamilyView ui changes #1863 closes #1863 changed overlay, added view photo button. added modal for displaying larger photo, displaying view photo button, using code from Initials.js if photo exists. * addressing review comments * UI Cleanup/bugs closes #2084 #2112 * UI Improvments closes #2112 * Apply fixes from StyleCI (#2113) * Fix database backup (#2118) * closes #2099 * Apply fixes from StyleCI * using github-release-notes in the bash script renamed the npm target updated changeslog.md * updated steps and included changelog task * Cash is displayed even if 0 #1852 (#1983) * resolves #1852 * still show 0 cash if 0 cash 💯 * applied styleci patch * Remove old changelog * start 2.6.2 (#2125) * this works on ASO demo site. (#2126) * #2121-unable to create event (#2122) add document ready function around the dateranger script. fixes #2121 * start 2.6.3 (#2127) * 2.6.3 * update changelog * Update CHANGELOG.md removed dbl logs * Feature/2124 notification bar (#2167) * Working POC * Fix styles * get data from web service * Apply fixes from StyleCI * allow for differentating admin vs all user notifications * add TTL setting for notifications * don't include system notifications locally * cleanup * underp boolean call * address comments - handle exceptions correctly * fix logic if captive portal intercepts notification request * rev jQuery-photo-uploader (#2185) * closes #2123 (#2184) * update changelog (#2190) * update changelog * 2.6.3 * locked to 0.6.3 * locked to 0.6.3 * Update CHANGELOG.md trim down to subset of changes * Add Behat tests to TravisCI (#2011) * underp master vs develop merge * underps * add test to travis * add apache to travis. * tweaks * change path * move to script. troubleshooting. * debugging * debugging * fix path * fix path * tweaks * tweaks * underp * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * move fpm conf * tweak * tweak * tweak * tweak * fingers crossed. * fingers crossed. * fingers crossed. * debug * tweak paths * tweak config * tweak config * permissions * permissions * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * tweaks * add config * tweaks * tweaks * revert login changes * change index * cleanup * underp php fpm * underp * rewrite? * rewrite? * SetHandler * use sockets * derppp * derppp * derppp sockets * derppp sockets * derppp sockets * proxy? * test? * tweaks? try again? * Important! Read the above again https://wiki.apache.org/httpd/PHP-FPM * tweak multi view * cleanup * Update Config.php * Update README.md (#2247) * added ignore question

simonkp added 3 commits January 30, 2017 17:49

Merge remote-tracking branch 'refs/remotes/ChurchCRM/master'

fa394e3

Merge remote-tracking branch 'refs/remotes/origin/master' into Church…

8996c9c

…CRM/master

fix membercount error

03ce080

fix #1924 * Apply left join onn family wher join with person to get the members without family accounted. * Also added Links to Family Roles section on membersdashboard.

DawoudIO added the In Review label Feb 14, 2017

simonkp mentioned this pull request Feb 14, 2017

BUG - 2.6.0-RC1: Member Count Error in Member Dashboard #1924

Closed

DawoudIO reviewed Feb 14, 2017

View reviewed changes

DawoudIO requested changes Feb 14, 2017

View reviewed changes

Changes to use SystemConfig

5c6dacc

using SystemConfig::getValue('sDirRoleChild')

DawoudIO added this to the 2.7.0 milestone Feb 17, 2017

DawoudIO added the bug label Feb 17, 2017

Merge branch 'master' into fix-#1924-membercounterror

59bf7ce

Merge branch 'master' into fix-#1924-membercounterror

0c1d4a2

DawoudIO modified the milestones: 2.7.0, 2.6.1 Mar 1, 2017

DawoudIO assigned rakess70 Mar 1, 2017

Merge branch 'master' into fix-#1924-membercounterror

d087bf1

DawoudIO assigned saulowulhynek and unassigned rakess70 Mar 5, 2017

Merge branch 'master' into fix-#1924-membercounterror

b8bd136

DawoudIO changed the title ~~Fix 1924 membercounterror~~ Member Count Error in Member Dashboard Mar 11, 2017

DawoudIO approved these changes Mar 11, 2017

View reviewed changes

DawoudIO merged commit cbafb7d into ChurchCRM:master Mar 11, 2017

DawoudIO removed the In Review label Mar 11, 2017

simonkp deleted the fix-#1924-membercounterror branch March 17, 2017 15:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Member Count Error in Member Dashboard #1925

Member Count Error in Member Dashboard #1925

simonkp commented Feb 14, 2017

DawoudIO Feb 14, 2017

simonkp Feb 14, 2017

simonkp Feb 14, 2017

DawoudIO left a comment

simonkp commented Feb 14, 2017

DawoudIO commented Feb 17, 2017

crossan007 commented Feb 18, 2017 •

edited

Loading

DawoudIO commented Feb 19, 2017

DawoudIO commented Feb 25, 2017

simonkp commented Feb 28, 2017

DawoudIO commented Mar 1, 2017

rakess70 commented Mar 4, 2017

DawoudIO commented Mar 5, 2017

DawoudIO commented Mar 5, 2017

Member Count Error in Member Dashboard #1925

Member Count Error in Member Dashboard #1925

Conversation

simonkp commented Feb 14, 2017

DawoudIO Feb 14, 2017

Choose a reason for hiding this comment

simonkp Feb 14, 2017

Choose a reason for hiding this comment

simonkp Feb 14, 2017

Choose a reason for hiding this comment

DawoudIO left a comment

Choose a reason for hiding this comment

simonkp commented Feb 14, 2017

DawoudIO commented Feb 17, 2017

crossan007 commented Feb 18, 2017 • edited Loading

DawoudIO commented Feb 19, 2017

DawoudIO commented Feb 25, 2017

simonkp commented Feb 28, 2017

DawoudIO commented Mar 1, 2017

rakess70 commented Mar 4, 2017

DawoudIO commented Mar 5, 2017

DawoudIO commented Mar 5, 2017

crossan007 commented Feb 18, 2017 •

edited

Loading