Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use multibyte substring for UTF-8 safe operations #1637

Merged
merged 3 commits into from
Jan 9, 2017

Conversation

crossan007
Copy link
Contributor

this should close the specific issue mentioned in #1282, but there is more work for full UTF8 compliance.

@DawoudIO DawoudIO added this to the 2.4.5 milestone Jan 8, 2017
@DawoudIO DawoudIO modified the milestones: 2.5.0, 2.4.5 Jan 8, 2017
@DawoudIO DawoudIO merged commit 325afd6 into master Jan 9, 2017
@DawoudIO DawoudIO removed the In Review label Jan 9, 2017
@DawoudIO DawoudIO deleted the 2.4.5-1282-multibyte-substring branch January 9, 2017 07:40
@dleigh
Copy link

dleigh commented Oct 22, 2017

Just to let you know, in the Directory Report free-form input text box at the bottom, diacritic accents are NOT handled well. Here's the text I put in:

Les membres actuels du conseil sont : Nadine Adriano, Isabelle Beck, Denis Bouchet, Huguette Brand, Luc et Manuela Bussière (couple pastoral), Stéphan Haffner, David et Angela Leigh, Vito et Jocelyne Pascazio et Alana Smith

Here's what came out:
Les membres actuels du conseil sont : Nadine Adriano, Isabelle Beck, Denis Bouchet,
Huguette Brand, Luc et Manuela Bussière (couple pastoral), Stéphan Haffner,
David et Angela Leigh, Vito et Jocelyne Pascazio et Alana Smith

Also if I put in multi-line text, such as:
Les membres actuels du conseil sont :
Nadine Adriano
sabelle Beck
Denis Bouchet
Huguette Brand
Luc et Manuela Bussière (couple pastoral)
Stéphan Haffner
David et Angela Leigh
Vito et Jocelyne Pascazio
Alana Smith

I get this:
Les membres actuels du conseil sont : \r\nNadine Adriano\r\nsabelle Beck\r\nDenis
Bouchet\r\nHuguette Brand\r\nLuc et Manuela Bussière (couple
pastoral)\r\nStéphan Haffner\r\nDavid et Angela Leigh\r\nVito et Jocelyne
Pascazio\r\nAlana Smith

This doesn't matter whether I put it into this screen or into the system config screens or directly into the database using phpmyadmin (I've not tried raw SQL and don't particularly want to go there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants