Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL substr->mb_substr big problem. #1722

Closed
crossan007 opened this issue Jan 16, 2017 · 1 comment · Fixed by #1732
Closed

SQL substr->mb_substr big problem. #1722

crossan007 opened this issue Jan 16, 2017 · 1 comment · Fixed by #1732
Assignees
@crossan007
Labels
bug
Milestone
2.5.0

Comments

@crossan007
Copy link
Contributor

this is a showstopper.

#1637 replaced all instances of substr() with mb_substr() but I didn't account for the fact that SQL has a substr function as well. SQL does not have an mb_substr() function, and this will cause big issues

All instances of mb_substr which are in a SQL query need to be reverted.
@crossan007 crossan007 added the bug label Jan 16, 2017
@crossan007 crossan007 added this to the 2.5.0 milestone Jan 16, 2017
@crossan007
Copy link
Contributor Author

This applies to JS as well...

@crossan007 crossan007 mentioned this issue Jan 17, 2017
Merged
@crossan007 crossan007 self-assigned this Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crossan007 crossan007

Labels
bug
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Fix SQL and JS mb_substr replace ChurchCRM/CRM
2 participants
@DawoudIO @crossan007