Allow PHP Variable changes for alpine images#8
Open
juanmrad wants to merge 5 commits intoChekote:masterfrom
Open
Allow PHP Variable changes for alpine images#8juanmrad wants to merge 5 commits intoChekote:masterfrom
juanmrad wants to merge 5 commits intoChekote:masterfrom
Conversation
Contributor
Author
|
@Chekote please don't forget this. I do have a question since apparently this alpine image has the following config files: There is no also tested by running: |
Owner
|
I feel like since the current setup for the Alpine images is not supporting a distinction between CLI and FPM, we should not pretend to support those in the Image. We should either only support PHP_ALL_ variables, or modify the Alpine image to make have a separate config for CLI and FPM. |
56200c8 to
851c931
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same changes done on pr #7 but for alpine entrypoint.