Skip to content

Commit 4585a29

Browse files
committed
Fix Laravel 10 build fails for PHP 8.3
Problem: The image fails to build stating that the base image does not exist. Cause: Laravel10.x is extending Laravel9.x, which is no longer built with PHP 8.3 as it does not support it. Fix: Extend Composer instead of Laravel9.x.
1 parent d33e51d commit 4585a29

File tree

2 files changed

+45
-6
lines changed

2 files changed

+45
-6
lines changed

laravel10.x.docker

Lines changed: 34 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,43 @@
44
# chekote/laravel10.x:php${PHP_MAJOR_VERSION}.${PHP_MINOR_VERSION}.${PHP_PATCH_VERSION}
55
# chekote/laravel10.x:php${PHP_MAJOR_VERSION}.${PHP_MINOR_VERSION}.${PHP_PATCH_VERSION}-$(date '+%Y-%m-%d-%H-%M-%S')
66
ARG PHP_VERSION=8.1
7-
FROM chekote/php:${PHP_VERSION}-laravel9.x
7+
FROM chekote/composer:php${PHP_VERSION}
88

99
ENV SUPPORTED_LARAVEL_VERSION '10.x'
1010
ENV MIN_PHP_VERSION '8.1'
11+
ENV MAX_PHP_VERSION '8.3.999'
1112

1213
RUN set -eu; \
1314
#
14-
check_php_version ${MIN_PHP_VERSION};
15+
check_php_version ${MIN_PHP_VERSION} ${MAX_PHP_VERSION}; \
16+
#
17+
apt-get update; \
18+
apt-get install -y --no-install-recommends --no-install-suggests \
19+
#
20+
# Laravel requirements
21+
# See https://laravel.com/docs/10.x/deployment#server-requirements
22+
# See https://github.com/laravel/laravel/blob/10.x/composer.json
23+
php${PHP_VERSION}-ctype \
24+
php${PHP_VERSION}-curl \
25+
php${PHP_VERSION}-dom \
26+
php${PHP_VERSION}-fileinfo \
27+
# php${PHP_VERSION}-filter \ (already included)
28+
# php${PHP_VERSION}-hash \ (already included)
29+
php${PHP_VERSION}-mbstring \
30+
# php${PHP_VERSION}-openssl \ (already included)
31+
# php${PHP_VERSION}-pcre \ (already included)
32+
php${PHP_VERSION}-pdo \
33+
# php${PHP_VERSION}-session \ (already included)
34+
php${PHP_VERSION}-tokenizer \
35+
php${PHP_VERSION}-xml \
36+
; \
37+
#
38+
# Cleanup
39+
apt-get autoremove -y; \
40+
apt-get clean; \
41+
rm -rf /var/lib/apt/lists/*; \
42+
rm -rf /var/cache/apt/*; \
43+
#
44+
# Make sure everything works
45+
php -v; \
46+
php-fpm${PHP_VERSION} -v

laravel9.x.docker

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,32 @@ FROM chekote/composer:php${PHP_VERSION}
88

99
ENV SUPPORTED_LARAVEL_VERSION '9.x'
1010
ENV MIN_PHP_VERSION '8.0'
11+
ENV MAX_PHP_VERSION '8.2.999'
1112

1213
RUN set -eu; \
1314
#
14-
check_php_version ${MIN_PHP_VERSION}; \
15+
check_php_version ${MIN_PHP_VERSION} ${MAX_PHP_VERSION}; \
1516
#
1617
apt-get update; \
17-
apt-get install -y --no-install-recommends \
18+
apt-get install -y --no-install-recommends --no-install-suggests \
1819
#
1920
# Laravel requirements
2021
# See https://laravel.com/docs/9.x/deployment#server-requirements
2122
# See https://github.com/laravel/laravel/blob/9.x/composer.json
2223
php${PHP_VERSION}-ctype \
2324
php${PHP_VERSION}-curl \
24-
php${PHP_VERSION}-dom; \
25+
php${PHP_VERSION}-dom \
26+
php${PHP_VERSION}-fileinfo \
27+
# php${PHP_VERSION}-filter \ (already included)
28+
# php${PHP_VERSION}-hash \ (already included)
2529
php${PHP_VERSION}-mbstring \
2630
# php${PHP_VERSION}-openssl \ (already included)
31+
# php${PHP_VERSION}-pcre \ (already included)
2732
php${PHP_VERSION}-pdo \
33+
# php${PHP_VERSION}-session \ (already included)
2834
php${PHP_VERSION}-tokenizer \
29-
php${PHP_VERSION}-xml; \
35+
php${PHP_VERSION}-xml \
36+
; \
3037
#
3138
# Cleanup
3239
apt-get autoremove -y; \

0 commit comments

Comments
 (0)