Skip to content

Conversation

hayescode
Copy link
Contributor

@hayescode hayescode commented Aug 26, 2025

Updated the structure of command translations and add them to every translation file. Follow-up to #2393

Before:
image

After:
image

  "commands": {
      "button": "Tools",
      "changeTool": "Change Tool",
      "availableTools": "Available Tools"
  },

No Text is also allowed (for copilot):
image

  "commands": {
      "button": "",
      "changeTool": "",
      "availableTools": ""
  },

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 26, 2025
@hayescode hayescode changed the title fix: add translations fix: add command translations Aug 26, 2025
Copy link
Contributor

@sandangel sandangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandangel sandangel added this pull request to the merge queue Aug 26, 2025
@sandangel sandangel removed this pull request from the merge queue due to a manual request Aug 26, 2025
@sandangel sandangel added this pull request to the merge queue Aug 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 26, 2025
@hayescode hayescode added this pull request to the merge queue Aug 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 26, 2025
@hayescode hayescode added this pull request to the merge queue Aug 26, 2025
Merged via the queue into main with commit 220ae7d Aug 26, 2025
22 of 27 checks passed
@hayescode hayescode deleted the fix/command_translations branch August 26, 2025 14:53
@AidanShipperley
Copy link
Contributor

Thank you for this @hayescode, I just noticed my translations were missing from #2393. I had something similar to this, but I must have forgot to push to the branch. Apologies for the trouble!

@hayescode
Copy link
Contributor Author

hayescode commented Aug 26, 2025

No worries thanks for your contribution on this I like it a lot!

zhou-san pushed a commit to zhou-san/chainlit that referenced this pull request Aug 28, 2025
Updated the structure of command translations and add them to every
translation file. Follow-up to Chainlit#2393

Before:
<img width="310" height="129" alt="image"
src="https://github.com/user-attachments/assets/0f88dba7-ae17-46b4-a41a-93230a6f9539"
/>

After:
<img width="300" height="116" alt="image"
src="https://github.com/user-attachments/assets/f2c9b51a-634f-4f8e-9da5-e1b9d116a401"
/>
```json
  "commands": {
      "button": "Tools",
      "changeTool": "Change Tool",
      "availableTools": "Available Tools"
  },
```


No Text is also allowed (for copilot):
<img width="294" height="128" alt="image"
src="https://github.com/user-attachments/assets/af5998dc-7d7c-44f6-87b9-27113739e485"
/>
```json
  "commands": {
      "button": "",
      "changeTool": "",
      "availableTools": ""
  },
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants