eslint warning removed from chain module#222
Merged
GregTheGreek merged 1 commit intomasterfrom May 23, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
- Coverage 69.1% 64.93% -4.17%
==========================================
Files 76 108 +32
Lines 1136 1788 +652
Branches 113 180 +67
==========================================
+ Hits 785 1161 +376
- Misses 324 596 +272
- Partials 27 31 +4 |
wemeetagain
approved these changes
May 23, 2019
GregTheGreek
approved these changes
May 23, 2019
matthewkeil
pushed a commit
that referenced
this pull request
Mar 26, 2025
**Motivation** I noticed what looks like a typo on MAX_REQUEST_DATA_COLUMN_SIDECARS. Spec is here: https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/p2p-interface.md#configuration <!-- Why is this PR exists? What are the goals of the pull request? --> **Description** Updates MAX_REQUEST_DATA_COLUMN_SIDECARS from 6384 to 16384 <!-- A clear and concise general description of the changes of this PR commits --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> **Steps to test or reproduce** <!--Steps to reproduce the behavior: ```sh git checkout <feature_branch> lodestar beacon --new-flag option1 ``` -->
matthewkeil
pushed a commit
that referenced
this pull request
Apr 14, 2025
**Motivation** @hughy and I have a basic implementation of [validator custody](https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/validator.md) for peerDAS. We're planning to do more testing on this, but would appreciate a review on the architecture since we're still pretty new! This relates to #7632 - If it merges, we'll update our PR to account for it. **Description** * Centralizes custody values like `sampledGroups` and `custodyGroups` into `CustodyConfig`. `CustodyConfig` is now treated as a singleton. * Creates a new `advertisedGroupCount` in `CustodyConfig`, used for the custody group count in the node's metadata/ENR. * Adds `setSamplingGroupCount` and `setAdvertisedGroupCount` to NetworkCore API. Updated by an `EventEmitter` on `CustodyConfig`. * Adds LocalValidatorRegistry to track connected validators. * Updates custody requirement in `chain.onForkChoiceFinalized`. **Not Included** I'll open separate issues for these if we're okay merging this PR without them. * Backfilling groups when the target custody group count increases * Handling changes in other peers' custody group counts * Race conditions around group count changing during syncing <!-- A clear and concise general description of the changes of this PR commits --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #7619 --------- Co-authored-by: Hugh Cunningham <hugh.e.cunningham@gmail.com>
matthewkeil
added a commit
that referenced
this pull request
Apr 17, 2025
**Motivation** <!-- Why is this PR exists? What are the goals of the pull request? --> **Description** <!-- A clear and concise general description of the changes of this PR commits --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number **Steps to test or reproduce** <!--Steps to reproduce the behavior: ```sh git checkout <feature_branch> lodestar beacon --new-flag option1 ``` --> --------- Co-authored-by: Derek Guenther <derek.guenther@coinbase.com>
nflaig
added a commit
that referenced
this pull request
Apr 29, 2025
…#7692) **Motivation** `feat(validator-monitor): Add block proposal summary panels to Grafana dashboard` **Description** This PR adds monitoring for validator block proposal performance . <!-- A clear and concise general description of the changes of this PR commits --> <!-- If applicable, add screenshots to help explain your solution --> <img width="1388" alt="Screenshot 2025-04-12 at 17 44 16" src="https://github.com/user-attachments/assets/f5fd7c20-bf4b-403b-9066-791ceb9f9672" /> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #6724 **Steps to test or reproduce** <!--Steps to reproduce the behavior: ```sh git checkout <feature_branch> lodestar beacon --new-flag option1 ``` --> --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
nflaig
added a commit
that referenced
this pull request
Aug 18, 2025
…7951) **Motivation** Fixes an issue in `getStateValidatorBalances` where `validator_index` fails to parse if it's not a hex string. <!-- Why is this PR exists? What are the goals of the pull request? --> **Description** <img width="913" alt="Screenshot 2025-06-11 at 10 23 43" src="https://github.com/user-attachments/assets/38e30b19-b2e1-4428-8c8c-4a297ffafc13" /> Note this was tested in dev mode <!-- A clear and concise general description of the changes of this PR commits --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #7881 **Steps to test or reproduce** Run in Dev mode: ``` ./lodestar dev ``` ``` curl http://localhost:9596/eth/v1/beacon/states/head/validator_balances?id=22710 /// Test with validator index 0 (should exist) curl http://localhost:9596/eth/v1/beacon/states/head/validator_balances?id=0 /// Check total validator count curl http://localhost:9596/eth/v1/beacon/states/head/validators | jq '.data | length' ``` <!--Steps to reproduce the behavior: ```sh ``` --> --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
wemeetagain
pushed a commit
that referenced
this pull request
Sep 4, 2025
**Motivation** <!-- Why is this PR exists? What are the goals of the pull request? --> **Description** This PR fixes an inconsistency in Lodestar's Beacon-API behavior when querying: ``` curl "http://127.0.0.1:9596/eth/v1/beacon/states/head/committees?epoch=2&slot=118" ``` Previously, Lodestar would return a `500 Internal Server Error` when the provided slot did not belong to the given epoch (e.g., `epoch=2&slot=118`), due to an unhandled `EPOCH_CONTEXT_ERROR_DECISION_ROOT_EPOCH_OUT_OF_RANGE` error. <img width="948" alt="Screenshot 2025-06-10 at 08 15 05" src="https://github.com/user-attachments/assets/7f6feea9-90c8-4299-ae0a-ce2a1e6a2282" /> <img width="948" alt="Screenshot 2025-06-10 at 08 14 33" src="https://github.com/user-attachments/assets/7fafea27-09a3-4f94-a5b6-d3a818ee5c65" /> <!-- A clear and concise general description of the changes of this PR commits --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #7882 **Steps to test or reproduce** <!--Steps to reproduce the behavior: ```sh git checkout <feature_branch> lodestar beacon --new-flag option1 ``` --> --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
nflaig
added a commit
that referenced
this pull request
Nov 3, 2025
**Motivation** Not resubscribing to beacon subnets (prepareBeaconCommitteeSubnet) as dependent root for current epoch changes. When this happens, previous subscriptions are no longer valid validator duties changed (slot, committee index, etc.) is_aggregator results are different **Description** Added subnet resubscription logic to `handleAttesterDutiesReorg` that fetches updated attester duties, rebuild beaconCommitteeSubscriptions and resubscribe validators to the correct beacon subnets by calling the prepareBeaconCommitteeSubnet api Added test to handle: - resubscribe to beacon subnets when current epoch dependent root changes, - resubscribe when next epoch dependent root changes and - not resubscribe when dependent root unchanged There was intentional use of claude AI in writing the test. <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #6034 **Steps to test or reproduce** <!--Steps to reproduce the behavior: ```sh git checkout <feature_branch> lodestar beacon --new-flag option1 ``` --> --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
wemeetagain
pushed a commit
that referenced
this pull request
Dec 1, 2025
**Motivation** - The era package was not mentioned in the readme. **Description** <!-- A clear and concise general description of the changes of this pull request. --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> **AI Assistance Disclosure** - [x] External Contributors: I have read the [contributor guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice) and disclosed my usage of AI below. <!-- Insert any AI assistance disclosure here -->
wemeetagain
pushed a commit
that referenced
this pull request
Dec 18, 2025
**Motivation** <!-- Why does this PR exist? What are the goals of the pull request? --> This PR is to fix eth-clients/mainnet#13 Already created this as well eth-clients/mainnet#14 <!-- A clear and concise general description of the changes of this pull request. --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number **AI Assistance Disclosure** - [ ] External Contributors: I have read the [contributor guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice) and disclosed my usage of AI below. <!-- Insert any AI assistance disclosure here -->
nazarhussain
pushed a commit
that referenced
this pull request
Jan 12, 2026
Updated Dockerfile to streamline installation and build process. **Motivation** After the last PR, the dockerfile wasn't building anymore. This PR fixes it. **Description** <!-- A clear and concise general description of the changes of this pull request. --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number **AI Assistance Disclosure** - [ ] External Contributors: I have read the [contributor guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice) and disclosed my usage of AI below. <!-- Insert any AI assistance disclosure here -->
nazarhussain
pushed a commit
that referenced
this pull request
Jan 12, 2026
Fixing [this](https://github.com/ethpandaops/ethereum-package/actions/runs/20928843912/job/60134147175#step:5:482) ```sh Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'triple-beam' imported from /usr/app/packages/logger/lib/interface.js at Object.getPackageJSONURL (node:internal/modules/package_json_reader:316:9) at packageResolve (node:internal/modules/esm/resolve:768:81) at moduleResolve (node:internal/modules/esm/resolve:858:18) at defaultResolve (node:internal/modules/esm/resolve:990:11) at #cachedDefaultResolve (node:internal/modules/esm/loader:718:20) at #resolveAndMaybeBlockOnLoaderThread (node:internal/modules/esm/loader:735:38) at ModuleLoader.resolveSync (node:internal/modules/esm/loader:764:52) at #resolve (node:internal/modules/esm/loader:700:17) at ModuleLoader.getOrCreateModuleJob (node:internal/modules/esm/loader:620:35) at ModuleJob.syncLink (node:internal/modules/esm/module_job:143:33) { code: 'ERR_MODULE_NOT_FOUND' } Node.js v24.12.0 ``` **Motivation** <!-- Why does this PR exist? What are the goals of the pull request? --> **Description** <!-- A clear and concise general description of the changes of this pull request. --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number **AI Assistance Disclosure** - [ ] External Contributors: I have read the [contributor guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice) and disclosed my usage of AI below. <!-- Insert any AI assistance disclosure here -->
ensi321
pushed a commit
that referenced
this pull request
Jan 16, 2026
**Motivation** implement eip 7843 **Description** <!-- A clear and concise general description of the changes of this pull request. --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number **AI Assistance Disclosure** me da monkey <img width="391" height="359" alt="Screenshot 2026-01-15 at 14 51 16" src="https://github.com/user-attachments/assets/7bb8913e-73d5-4531-979c-fdbae9dbfcf5" /> - [ ] External Contributors: I have read the [contributor guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice) and disclosed my usage of AI below. <!-- Insert any AI assistance disclosure here --> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
ensi321
pushed a commit
that referenced
this pull request
Jan 16, 2026
**Motivation** implement eip 7843 **Description** <!-- A clear and concise general description of the changes of this pull request. --> <!-- If applicable, add screenshots to help explain your solution --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #issue_number **AI Assistance Disclosure** me da monkey <img width="391" height="359" alt="Screenshot 2026-01-15 at 14 51 16" src="https://github.com/user-attachments/assets/7bb8913e-73d5-4531-979c-fdbae9dbfcf5" /> - [ ] External Contributors: I have read the [contributor guidelines](https://github.com/ChainSafe/lodestar/blob/unstable/CONTRIBUTING.md#ai-assistance-notice) and disclosed my usage of AI below. <!-- Insert any AI assistance disclosure here --> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning removed from the new master branch.