Conversation
**Motivation** It'd be nice to get tests and lints passing on the peerDAS branch, both to get it ready to merge into unstable and so we can check PRs into the peerDAS branch. **Description** The only intended functional change is to `initPeerIdAndEnr`, will add a comment on that change. It might be easier to review commit by commit, to more easily view the lint fixes separately from the unit test fixes.
**Motivation** Fixes an error in the spec test, as well as an error in the e2e tests. This might not fix all the e2e test issues, but I still need to get my e2e environment set up locally. **Description** * Continues skipping the test for single_merkle_proof. This is removed for fulu in 1.5.0-beta4 tests, but might as well fix it for now * Allows the params e2e tests to run on Fulu -- everything is implemented there anyway
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## peerDAS #7716 +/- ##
==========================================
Coverage ? 42.60%
==========================================
Files ? 732
Lines ? 52680
Branches ? 2265
==========================================
Hits ? 22443
Misses ? 30195
Partials ? 42 🚀 New features to boost your workflow:
|
Member
|
🎉 This PR is included in v1.34.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes #issue_number
Steps to test or reproduce