-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chainsafe/eslint-config #6011
Comments
We should use all this in our packages for the benefit of all ChainSafe users |
cc: @mpetrunic . Thoughts? |
To continue on this discussion and if we proceed to use this instead, we should consider how it will affect these: Bump for opinion from @mpetrunic |
I am not sure having all lint config in a module is that great as it is less flexible. Lodestar is a huge codebase and different from libraries in some ways. Of course we could just override lint rules were needed but then we lose most of the advantages anyways of reusing from a module and at the same time have less transparency on the lint rules as they are not part of the codebase. |
I think flexibility isn't so much of a concern here because rules don't change very often. Also not convinced that lint rules should be different in libraries, can't really think of a case where that should happen. |
Problem description
Our repos all use slightly different linting rules. There's a bit of maintenance friction that can be mitigated.
Solution description
Evaluate, contribute to, and use the chainsafe eslint-config here and in our other repos.
We should upstream as many linter rules as we can (as many rules as makes sense).
Additional context
See https://github.com/ChainSafe/eslint-config
The text was updated successfully, but these errors were encountered: