Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chainsafe/eslint-config #6011

Open
wemeetagain opened this issue Sep 30, 2023 · 5 comments
Open

Use chainsafe/eslint-config #6011

wemeetagain opened this issue Sep 30, 2023 · 5 comments
Labels
meta-discussion Indicates a topic that requires input from various developers. meta-feature-request Issues to track feature requests. scope-devex Issues for improving developer experience.

Comments

@wemeetagain
Copy link
Member

Problem description

Our repos all use slightly different linting rules. There's a bit of maintenance friction that can be mitigated.

Solution description

Evaluate, contribute to, and use the chainsafe eslint-config here and in our other repos.
We should upstream as many linter rules as we can (as many rules as makes sense).

Additional context

See https://github.com/ChainSafe/eslint-config

@philknows
Copy link
Member

We should use all this in our packages for the benefit of all ChainSafe users

@philknows
Copy link
Member

cc: @mpetrunic . Thoughts?

@philknows philknows added scope-devex Issues for improving developer experience. meta-discussion Indicates a topic that requires input from various developers. labels Nov 29, 2023
@philknows
Copy link
Member

To continue on this discussion and if we proceed to use this instead, we should consider how it will affect these:

#5566
#5505
#5242
#3929

Bump for opinion from @mpetrunic

@nflaig
Copy link
Member

nflaig commented Feb 6, 2024

I am not sure having all lint config in a module is that great as it is less flexible. Lodestar is a huge codebase and different from libraries in some ways. Of course we could just override lint rules were needed but then we lose most of the advantages anyways of reusing from a module and at the same time have less transparency on the lint rules as they are not part of the codebase.

@wemeetagain
Copy link
Member Author

I think flexibility isn't so much of a concern here because rules don't change very often.
But flexibility is definitely the tradeoff. The benefit would be consistency.

Also not convinced that lint rules should be different in libraries, can't really think of a case where that should happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-discussion Indicates a topic that requires input from various developers. meta-feature-request Issues to track feature requests. scope-devex Issues for improving developer experience.
Projects
None yet
Development

No branches or pull requests

3 participants