Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent package configuration on Lodestar libs #2459

Open
1 of 8 tasks
dapplion opened this issue May 1, 2021 · 4 comments
Open
1 of 8 tasks

Consistent package configuration on Lodestar libs #2459

dapplion opened this issue May 1, 2021 · 4 comments
Labels
prio-low This is nice to have. scope-none Issues that do not fit within any of the other defined scopes.

Comments

@dapplion
Copy link
Contributor

dapplion commented May 1, 2021

There are some actions that should be done on all Lodestar libraries that are not in the monorepo:

  • Add CI: A Github Actions workflow that builds, tests and lints
  • Same Typescript, linter and prettier dependency versions are used as in the Lodestar monorepo
  • Same tsconfig.json is used. @3xtr4t3rr3str14l Already started on this item by setting strictNullChecks = true
  • Same prettier settings are used
  • Same eslintrc settings are used
  • Add codeowners with the entire Eth2.0 team so reviewers are asked automatically
  • Review READMEs that link to the Lodestar project
  • Apply README checks (i.e. what is basically outlined in Investigate and implement tooling to ensure README files are accurate across all packages #2828)
@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the bot:stale label Jul 8, 2021
@3xtr4t3rr3str14l 3xtr4t3rr3str14l self-assigned this Jul 8, 2021
@stale stale bot removed the bot:stale label Jul 8, 2021
@3xtr4t3rr3str14l
Copy link
Contributor

once #2841 is approved and merged, we should apply the same process to the other lodestar-related packages that are not housed within the monorepo (ssz, bls, etc)

@dapplion
Copy link
Contributor Author

@wemeetagain After merging SSZ repos and BLS repos we should apply this issue to them to on par with the Lodestar monorepo

@philknows philknows added the scope-none Issues that do not fit within any of the other defined scopes. label Sep 8, 2022
@wemeetagain
Copy link
Member

related to #6011

@philknows philknows changed the title Maintenance - Lodestar libs Consistent package configuration on Lodestar libs Nov 5, 2023
@philknows philknows added the prio-low This is nice to have. label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-low This is nice to have. scope-none Issues that do not fit within any of the other defined scopes.
Projects
None yet
Development

No branches or pull requests

4 participants