chore(lint): check each //nolint and improve them
#2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2047 +/- ##
===============================================
+ Coverage 59.94% 60.23% +0.29%
===============================================
Files 185 194 +9
Lines 26343 26589 +246
===============================================
+ Hits 15790 16016 +226
- Misses 8677 8692 +15
- Partials 1876 1881 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
qdm12
requested review from
arijitAD,
EclesioMeloJunior,
edwardmack,
jimjbrettj,
kishansagathiya,
noot,
omar391 and
timwu20
as code owners
noot
reviewed
Nov 22, 2021
noot
approved these changes
Nov 22, 2021
EclesioMeloJunior
approved these changes
Nov 23, 2021
2 tasks
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
timwu20
pushed a commit
to timwu20/gossamer
that referenced
this pull request
Dec 6, 2021
- remove unneeded `//nolint` comments - fix some of the lint-ignored errors - specify a linter that should be ignored as `//nolint:lintername` - add `nolintlint` linter to detect future unused `//nolint` comments - move exclude rules from golangci.yml to inlined `//nolint` so `nolintlint` can pick them up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
//nolintcomments//nolint:linternamenolintlintlinter to detect future unused//nolintcomments//nolintsonolintlintcan pick them up.The idea behind those changes was to find potential code issues that could be the root of the memory issue
Tests
Issues
Primary Reviewer