Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve linting to detect potential memory problems #1974

Closed
2 tasks done
qdm12 opened this issue Nov 3, 2021 · 3 comments
Closed
2 tasks done

Improve linting to detect potential memory problems #1974

qdm12 opened this issue Nov 3, 2021 · 3 comments

Comments

@qdm12
Copy link
Contributor

qdm12 commented Nov 3, 2021 •
edited
Loading

  • Check // nolint comments
    • Check it makes sense to ignore
    • Replace each with //nolint:<linter>
    • Add nolintlint linter so outdated //nolint comments are detected
  • Add linters nilerr, nilnil and exportloopref
@noot
Copy link
Contributor

noot commented Nov 25, 2021

@qdm12 is this done?

@qdm12 qdm12 mentioned this issue Nov 26, 2021
Merged
@qdm12
Copy link
Contributor Author

qdm12 commented Nov 26, 2021

First part is done in #2047, I just did the second part in #2072

@qdm12
Copy link
Contributor Author

qdm12 commented Dec 16, 2021

Done in #2047 and #2072

@qdm12 qdm12 closed this as completed Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danforbes @qdm12 @noot