[ENG-7263] Part 2#11110
Merged
brianjgeiger merged 4 commits intoCenterForOpenScience:feature/pbs-25-08from Apr 24, 2025
Merged
Conversation
brianjgeiger
requested changes
Apr 24, 2025
Collaborator
There was a problem hiding this comment.
The provided_pid changes in the management command look right, but the changes to the model seem wrong. Did you mean to do those? Also, there were, I think, 2 errors in the document I sent you, not just the provided_pid error. The other was a list index our of range error such as:
[osf.management.commands.fix_unclaimed_records_for_preprint_versions] INFO: Found 2 unregistered contributors for preprint 6ct2h_v1
[osf.management.commands.fix_unclaimed_records_for_preprint_versions] ERROR: Error processing contributor 623: list index out of range
[osf.management.commands.fix_unclaimed_records_for_preprint_versions] ERROR: Error processing contributor 622: list index out of range
Collaborator
|
Also, can we safely run the management command again on the same staging environment once this is fixed? |
Contributor
Author
Changes to the model appeared when I rebased pbs-25-08 branch because there were merge conflicts. |
Contributor
Author
Yeah it should be safe. There is dry-run mode for this command |
brianjgeiger
approved these changes
Apr 24, 2025
brianjgeiger
merged commit 7e0c97b
into
CenterForOpenScience:feature/pbs-25-08
6 checks passed
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
May 1, 2025
…cience/osf.io into impact-notifications * 'feature/pbs-25-08' of https://github.com/CenterForOpenScience/osf.io: (28 commits) [ENG-7716] Allow for reinstatement of previous preprint versions (with date uploaded) via the admin app (CenterForOpenScience#11118) [ENG-7263] Fix/eng 7263 part 3 (CenterForOpenScience#11119) [ENG-7263] Part 2 (CenterForOpenScience#11110) fix feature for non-contributor admin (CenterForOpenScience#11111) [ENG-7716] Allow for reinstatement of previous preprint versions (with date uploaded) via the admin app (CenterForOpenScience#11097) delete sharev2 push [ENG-7387] (CenterForOpenScience#11032) [ENG-7503] Fix/eng 7503 (CenterForOpenScience#11092) [ENG-7263] Fix/eng 7263 (CenterForOpenScience#11090) [ENG-7798] Parse versioned guid (CenterForOpenScience#11104) [ENG-7270] Enable Product Team to Force Archive Registrations in the Admin App (CenterForOpenScience#11105) gdpr deletion shouldn't take into account deleted nodes (CenterForOpenScience#11098) Bind task for proper retrying improved naming use newly built doi for previous versions mint missing doi when build metadata use minted doi for building metadata updated error text simplified query flat guids added version filtering ... # Conflicts: # api/crossref/views.py # tests/test_events.py # tests/test_misc_views.py
Vlad0n20
added a commit
to Vlad0n20/osf.io
that referenced
this pull request
May 5, 2025
## Purpose Fix the errors in the management command ## Changes Remove useless parameter ## Ticket https://openscience.atlassian.net/browse/ENG-7263
ihorsokhanexoft
pushed a commit
to ihorsokhanexoft/osf.io
that referenced
this pull request
Jun 4, 2025
## Purpose Fix the errors in the management command ## Changes Remove useless parameter ## Ticket https://openscience.atlassian.net/browse/ENG-7263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the error in the manage command
Changes
Remove useless parameter
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-7263?atlOrigin=eyJpIjoiMjlhYWY5YjdmNmM2NDQ1N2JjYzBjMmE1MTZkODM1NTciLCJwIjoiaiJ9