[ENG-7557] Ignore deleted nodes when do gdpr deletion in admin#11098
Merged
brianjgeiger merged 1 commit intoCenterForOpenScience:feature/pbs-25-08from Apr 21, 2025
Merged
Conversation
brianjgeiger
changed the base branch from
feature/pbs-25-07
to
feature/pbs-25-08
brianjgeiger
approved these changes
Apr 21, 2025
brianjgeiger
merged commit b9e5e78
into
CenterForOpenScience:feature/pbs-25-08
6 checks passed
Johnetordoff
added a commit
to Johnetordoff/osf.io
that referenced
this pull request
May 1, 2025
…cience/osf.io into impact-notifications * 'feature/pbs-25-08' of https://github.com/CenterForOpenScience/osf.io: (28 commits) [ENG-7716] Allow for reinstatement of previous preprint versions (with date uploaded) via the admin app (CenterForOpenScience#11118) [ENG-7263] Fix/eng 7263 part 3 (CenterForOpenScience#11119) [ENG-7263] Part 2 (CenterForOpenScience#11110) fix feature for non-contributor admin (CenterForOpenScience#11111) [ENG-7716] Allow for reinstatement of previous preprint versions (with date uploaded) via the admin app (CenterForOpenScience#11097) delete sharev2 push [ENG-7387] (CenterForOpenScience#11032) [ENG-7503] Fix/eng 7503 (CenterForOpenScience#11092) [ENG-7263] Fix/eng 7263 (CenterForOpenScience#11090) [ENG-7798] Parse versioned guid (CenterForOpenScience#11104) [ENG-7270] Enable Product Team to Force Archive Registrations in the Admin App (CenterForOpenScience#11105) gdpr deletion shouldn't take into account deleted nodes (CenterForOpenScience#11098) Bind task for proper retrying improved naming use newly built doi for previous versions mint missing doi when build metadata use minted doi for building metadata updated error text simplified query flat guids added version filtering ... # Conflicts: # api/crossref/views.py # tests/test_events.py # tests/test_misc_views.py
Vlad0n20
pushed a commit
to Vlad0n20/osf.io
that referenced
this pull request
May 5, 2025
…nScience#11098) ## Purpose When user has a deleted node where he is the only admin, osf admin can't gdpr delete this user because of this error ## Changes Ignore this message for deleted nodes. Added a test ## Ticket https://openscience.atlassian.net/browse/ENG-7557
ihorsokhanexoft
added a commit
to ihorsokhanexoft/osf.io
that referenced
this pull request
Jun 4, 2025
…nScience#11098) ## Purpose When user has a deleted node where he is the only admin, osf admin can't gdpr delete this user because of this error ## Changes Ignore this message for deleted nodes. Added a test ## Ticket https://openscience.atlassian.net/browse/ENG-7557
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When user has a deleted node where he is the only admin, osf admin can't gdpr delete this user because of this error
Changes
Ignore this message for deleted nodes. Added a test
Ticket
https://openscience.atlassian.net/jira/software/c/projects/ENG/boards/145/backlog?assignee=712020%3A7c7368dc-40cb-475f-bae8-b07a8bd2dd6c&selectedIssue=ENG-7557