Modify CI to run directed-minimal-versions #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
-Zdirected-minimal-versions
will run with the minimal versions of the specified direct dependencies (of rune and all workspace crates), but the maximum indirect dependencies. This means that we won't fail CI for any issues our direct deps have with-Zminimal-versions
.Additionally, fixed some of the versions that were selected for syn, quote and proc-macro2. It's recommended to use qualified versions, to avoid issues with minimal versions.
Risks associated with this change
I don't really see a risk of taking a dependency on
-Zdirected-minimal-versions
. Here's the documentation, and why I think it's particularly useful for our crate (s, as it counts the workspace). Taiki Endo is also the creator of cargo-hack, which we also plan to use here.source
Testing
Ran CI on my own commit on my fork, you can find the test run here: https://github.com/Qkessler/rune/actions/runs/7072080397/job/19250513320