Skip to content

Commit

Permalink
Modify CI to run directed-minimal-versions (#41)
Browse files Browse the repository at this point in the history
`-Zdirected-minimal-versions` will run with the minimal versions of the
specified direct dependencies (of rune and all workspace crates), but
the maximum indirect dependencies. This means that we won't fail CI for
any issues our direct deps have with `-Zminimal-versions`.

Additionally, fixed some of the versions that were selected for syn,
quote and proc-macro2. It's recommended to use qualified versions, to
avoid issues with minimal versions.
  • Loading branch information
Qkessler authored Dec 2, 2023
1 parent 075f5e6 commit 3d2ca3d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 13 deletions.
12 changes: 5 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ jobs:
# Cargo build order. See also
# https://github.com/jonhoo/fantoccini/blob/fde336472b712bc7ebf5b4e772023a7ba71b2262/Cargo.toml#L47-L49.
# This action is run on ubuntu with the stable toolchain, as it is not expected to fail
# disable this job until we can fix it.
if: false
runs-on: ubuntu-latest
name: ubuntu / stable / minimal-versions
steps:
Expand All @@ -77,14 +75,14 @@ jobs:
run: sudo apt-get -y install libpango1.0-dev libgtk-3-dev
- name: Install stable
uses: dtolnay/rust-toolchain@stable
- name: Install nightly for -Zminimal-versions
- name: Install nightly for -Zdirected-minimal-versions
uses: dtolnay/rust-toolchain@nightly
- name: rustup default stable
run: rustup default stable
- name: cargo update -Zminimal-versions
run: cargo +nightly update -Zminimal-versions
- name: cargo test
run: cargo test --workspace --locked --all-features
- uses: taiki-e/install-action@cargo-hack
- uses: taiki-e/install-action@cargo-minimal-versions
- name: Check directed-minimal-versions
run: cargo minimal-versions check --direct
os-check:
# run cargo test on mac and windows
runs-on: ${{ matrix.os }}
Expand Down
6 changes: 3 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ default = []
debug_bytecode = []

[build-dependencies]
syn = "2.0"
quote = "1.0"
proc-macro2 = "1.0"
syn = "2.0.15"
quote = "1.0.26"
proc-macro2 = "1.0.60"

[workspace.lints.rust]
macro_use_extern_crate = "deny"
Expand Down
6 changes: 3 additions & 3 deletions fn_macros/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ path = "lib.rs"
proc-macro = true

[dependencies]
quote = "1.0"
quote = "1.0.26"
darling = "0.20"
syn = { version = "2.0", features = ["full"]}
proc-macro2 = "1.0"
syn = { version = "2.0.15", features = ["full"]}
proc-macro2 = "1.0.60"

[lints]
workspace = true

0 comments on commit 3d2ca3d

Please sign in to comment.