Skip to content

Conversation

@cg-julian-taylor
Copy link
Collaborator

No description provided.

@cg-julian-taylor cg-julian-taylor marked this pull request as draft December 19, 2022 17:00
@cg-julian-taylor cg-julian-taylor marked this pull request as ready for review December 19, 2022 17:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (1934018) compared to base (bbb7e14).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 1934018 differs from pull request most recent head 3614bea. Consider uploading reports for the commit 3614bea to get more accurate results

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/radio-and-checkbox      #373   +/-   ##
============================================================
  Coverage                      100.00%   100.00%           
============================================================
  Files                              44        44           
  Lines                            1062      1062           
  Branches                          414       414           
============================================================
  Hits                             1062      1062           
Impacted Files Coverage Δ
src/checkboxGroup/CheckboxGroup.tsx 100.00% <100.00%> (ø)
src/common/components/FormRadioCheckboxBase.tsx 100.00% <100.00%> (ø)
src/radioGroup/RadioGroup.tsx

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daniele-zurico daniele-zurico merged commit 0cdb84e into feature/radio-and-checkbox Dec 20, 2022
@daniele-zurico daniele-zurico deleted the task/create-checkbox-group branch December 20, 2022 09:47
daniele-zurico pushed a commit that referenced this pull request Dec 20, 2022
* feat: remove <FormRadio> storybook (#369)

* feat: Deprecate <FormRadio> (#370)

* feat: remove <FormGroup /> and related stories

* Task create form radio (#371)

* feat: Deprecate <FormRadio>

* feat: add <FormRadio /> component

* feat: add <FormRadioCheckboxBase> component

* feat: update dev script

* feat: move <FormGroup /> to <FormRadio />

* feat: rename test FormGroup to RadioGroup

* feat: add storybook documentation

* feat: Rename StyledRadios to Styled

* feat: Fix unstyled stories

* Task create checkbox group (#373)

* feat: create <CheckboxGroup /> component

* feat: update test

* feat: fix test. Was looking for wrong element

* feat: update storybook documentation (#378)

* feat: remove "unstyled" dir from radioGroup story

* feat: update storybook doc for single checkbox (#381)

* Correct single checkbox stories (#382)

* feat: correct <FormCheckbox /> Stories

* feat: correct <FormCheckbox /> Stories

* feat: add class to fix styling (#383)
daniele-zurico added a commit that referenced this pull request Jan 18, 2023
* feat: add value to button

* feat:select-containerId (#350)

* fix: On initial render, ensure that the input prompt for Autocomplete is not visible unless focused (#357)

* Feature/upgrade deps (#359)

* feat: upgrade deps

* feat: downgrade microbundle

* Autocomplete: Ensure the value of controlled input is never undefined (#358)

* feat: upgrade microbundle (#360)

* fix: Accessibility improvements (#361)

* Feature/autocomplete (#364)

* feat: add dynamic id to the list

* feat: add dynamic id to the list

* feat: change on the id

* feat: remove jss dependecy (#365)

* Make onChange prop optional for FormGroup component (#368)

* feat: use sass library instead of node-sass

* feat: onChange type now optional

* Separate radio and checkbox groups (#380)

* feat: remove <FormRadio> storybook (#369)

* feat: Deprecate <FormRadio> (#370)

* feat: remove <FormGroup /> and related stories

* Task create form radio (#371)

* feat: Deprecate <FormRadio>

* feat: add <FormRadio /> component

* feat: add <FormRadioCheckboxBase> component

* feat: update dev script

* feat: move <FormGroup /> to <FormRadio />

* feat: rename test FormGroup to RadioGroup

* feat: add storybook documentation

* feat: Rename StyledRadios to Styled

* feat: Fix unstyled stories

* Task create checkbox group (#373)

* feat: create <CheckboxGroup /> component

* feat: update test

* feat: fix test. Was looking for wrong element

* feat: update storybook documentation (#378)

* feat: remove "unstyled" dir from radioGroup story

* feat: update storybook doc for single checkbox (#381)

* Correct single checkbox stories (#382)

* feat: correct <FormCheckbox /> Stories

* feat: correct <FormCheckbox /> Stories

* feat: add class to fix styling (#383)

* fix: add correct components to example src (#385)

* feat: move elements outside of label (#387)

* Conditionally render aria-label (#386)

* feat: conditionally render aria-label

* feat: unit test failed eslint checks

* Feature/upgrade storybook (#392)

* feat: update storybook

* feat: update storybook

* Feature/tab index (#389)

* fix: tabIndex prop for Button CopyToClipboard Details and FormDate

* fix: tabIndex type to string

* fix: tabIndex back to number

* fix: tabIndex and missing tests

* fix: updated liveEdit files

Co-authored-by: Daniele Zurico <daniele.zurico@gmail.com>

* fix: allow closing of the options list with the Escape key instead of onBlur (#400)

* Feat/update readme (#391)

* Update CHANGELOG.md

Co-authored-by: SergioBandera <113599747+SergioBanderaGarcia@users.noreply.github.com>
Co-authored-by: Sri Viswanathan <sri@protodiv.com>
Co-authored-by: cg-julian-taylor <107050226+cg-julian-taylor@users.noreply.github.com>
Co-authored-by: Szilvi Horvath <szilvi.horvath@capgemini.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants