Skip to content

Conversation

@daniele-zurico
Copy link
Contributor

if specified it will add a dynamic id to the list of the options provided.

Parameter: optionsId

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (c23f2f2) compared to base (aefc3eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.6      #364   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               43        43           
  Lines             1007      1008    +1     
  Branches           388       389    +1     
=============================================
+ Hits              1007      1008    +1     
Impacted Files Coverage Δ
src/autocomplete/Autocomplete.tsx 100.00% <ø> (ø)
src/autocomplete/ResultList.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ibabalola Ibabalola added the enhancement New feature or request label Dec 3, 2022
@Ibabalola Ibabalola added this to the 0.6 milestone Dec 3, 2022
@Ibabalola Ibabalola linked an issue Dec 3, 2022 that may be closed by this pull request
@Ibabalola Ibabalola merged commit d6dc2fd into release/0.6 Dec 5, 2022
daniele-zurico added a commit that referenced this pull request Jan 18, 2023
* feat: add value to button

* feat:select-containerId (#350)

* fix: On initial render, ensure that the input prompt for Autocomplete is not visible unless focused (#357)

* Feature/upgrade deps (#359)

* feat: upgrade deps

* feat: downgrade microbundle

* Autocomplete: Ensure the value of controlled input is never undefined (#358)

* feat: upgrade microbundle (#360)

* fix: Accessibility improvements (#361)

* Feature/autocomplete (#364)

* feat: add dynamic id to the list

* feat: add dynamic id to the list

* feat: change on the id

* feat: remove jss dependecy (#365)

* Make onChange prop optional for FormGroup component (#368)

* feat: use sass library instead of node-sass

* feat: onChange type now optional

* Separate radio and checkbox groups (#380)

* feat: remove <FormRadio> storybook (#369)

* feat: Deprecate <FormRadio> (#370)

* feat: remove <FormGroup /> and related stories

* Task create form radio (#371)

* feat: Deprecate <FormRadio>

* feat: add <FormRadio /> component

* feat: add <FormRadioCheckboxBase> component

* feat: update dev script

* feat: move <FormGroup /> to <FormRadio />

* feat: rename test FormGroup to RadioGroup

* feat: add storybook documentation

* feat: Rename StyledRadios to Styled

* feat: Fix unstyled stories

* Task create checkbox group (#373)

* feat: create <CheckboxGroup /> component

* feat: update test

* feat: fix test. Was looking for wrong element

* feat: update storybook documentation (#378)

* feat: remove "unstyled" dir from radioGroup story

* feat: update storybook doc for single checkbox (#381)

* Correct single checkbox stories (#382)

* feat: correct <FormCheckbox /> Stories

* feat: correct <FormCheckbox /> Stories

* feat: add class to fix styling (#383)

* fix: add correct components to example src (#385)

* feat: move elements outside of label (#387)

* Conditionally render aria-label (#386)

* feat: conditionally render aria-label

* feat: unit test failed eslint checks

* Feature/upgrade storybook (#392)

* feat: update storybook

* feat: update storybook

* Feature/tab index (#389)

* fix: tabIndex prop for Button CopyToClipboard Details and FormDate

* fix: tabIndex type to string

* fix: tabIndex back to number

* fix: tabIndex and missing tests

* fix: updated liveEdit files

Co-authored-by: Daniele Zurico <daniele.zurico@gmail.com>

* fix: allow closing of the options list with the Escape key instead of onBlur (#400)

* Feat/update readme (#391)

* Update CHANGELOG.md

Co-authored-by: SergioBandera <113599747+SergioBanderaGarcia@users.noreply.github.com>
Co-authored-by: Sri Viswanathan <sri@protodiv.com>
Co-authored-by: cg-julian-taylor <107050226+cg-julian-taylor@users.noreply.github.com>
Co-authored-by: Szilvi Horvath <szilvi.horvath@capgemini.com>
@daniele-zurico daniele-zurico deleted the feature/autocomplete-id branch March 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add configurable id to Autocomplete Result items <li/>

4 participants