-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fixes: Fix deleting caps within folders and duplicate refresh route #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces memoized filtering to hide the currently uploading video in lists, adjusts deletion to support both bulk and single-item flows with updated mutation wiring, and refreshes the router after duplication. Minor text tweaks and UI checks now use the filtered list. Database file has whitespace-only comment changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as FolderVideosSection
participant API as RPC
participant Router
rect rgba(230,245,255,0.6)
note over UI: Delete action
User->>UI: Click Delete
alt Selected caps exist
UI->>API: deleteCaps(ids[])
API-->>UI: Success/Failure
else Single item
UI->>API: deleteCap(id)
API-->>UI: Success/Failure
end
opt On success
UI->>Router: refresh()
end
end
sequenceDiagram
autonumber
actor User
participant Card as CapCard
participant API as RPC
participant Router
rect rgba(240,255,240,0.6)
note over Card: Duplicate action
User->>Card: Click "Duplicate"
Card->>API: duplicateMutation(capId)
API-->>Card: Success/Failure
opt On success
Card->>Router: refresh()
end
end
sequenceDiagram
autonumber
participant State as State (data, isUploading, uploadingCapId)
participant Component as Caps/FolderVideosSection
rect rgba(255,250,230,0.6)
note over Component: Visible list computation
State-->>Component: inputs change
Component->>Component: useMemo filter: exclude uploadingCapId when isUploading
Component-->>Component: visibleVideos used for render
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR:
Summary by CodeRabbit
New Features
Bug Fixes
UI/UX