improvement: remove loading spinner from next to trash icon

[ameer2468]

Summary by CodeRabbit

• Improvements

  • Deleting one or multiple items is now a direct action across cards, selection bar, and keyboard shortcuts for a faster, more responsive feel.
  • Confirmation dialog closes immediately after confirming deletion.
  • Loading state is unified: delete buttons disable while processing; button spinner is removed.

• Refactor

  • Simplified internal deletion handling for consistency across the dashboard.
  • Consolidated component imports via a single components entry point (no behavioral changes).

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Refactors deletion mutations in Caps dashboard to use destructured mutate functions and separate isPending flags. Updates CapCard onDelete to a void callback and adjusts handlers to call deletion functions directly. SelectedCapsBar’s confirm handler becomes synchronous. Adds a barrel exports file for components and consolidates imports accordingly.

Changes

Cohort / File(s)	Summary of Change
Deletion mutation API refactor apps/web/app/(org)/dashboard/caps/Caps.tsx	Destructure mutation hooks: { mutate: deleteCaps, isPending: isDeletingCaps } and { mutate: deleteCap, isPending: isDeletingCap }. Replace .mutate/.mutateAsync with direct calls deleteCaps(ids) / deleteCap(id). Update keyboard and UI handlers; combine loading state `isDeletingCaps
CapCard onDelete signature change apps/web/app/(org)/dashboard/caps/components/CapCard/CapCard.tsx	onDelete prop changes from () => Promise<any> to () => void. Internal mutation flow now triggers a void callback; async awaiting of onDelete is removed.
Selected caps delete flow adjustment apps/web/app/(org)/dashboard/caps/components/SelectedCapsBar.tsx	handleConfirmDelete made synchronous; call deleteSelectedCaps() then close dialog. Remove button spinner={isDeleting}; keep disabled state via isDeleting.
Components barrel export apps/web/app/(org)/dashboard/caps/components/index.ts	New barrel re-exporting: ./CapPagination, ./EmptyCapState, ./Folder, ./NewFolderDialog, ./SelectedCapsBar, ./UploadCapButton, ./UploadPlaceholderCard. Enables aggregated imports.

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant UI as Caps UI (Grid / Bar)
  participant CapCard as CapCard
  participant Caps as Caps.tsx
  participant Mut as useEffectMutation

  rect rgb(245,248,255)
    note over User,UI: Deletion triggered (button, keyboard, or CapCard menu)
    User->>UI: Click Delete / Press Del
    UI->>CapCard: onDelete() (void)
    CapCard->>Caps: onDelete handler invoked
  end

  alt Multiple selected
    Caps->>Mut: deleteCaps(selectedIds)
    Mut-->>Caps: isDeletingCaps true/false
  else Single item
    Caps->>Mut: deleteCap(id)
    Mut-->>Caps: isDeletingCap true/false
  end

  note over UI: Loading/disabled bound to isDeletingCaps || isDeletingCap

  rect rgb(255,249,245)
    note over UI: SelectedCapsBar confirm
    User->>UI: Confirm delete
    UI->>Caps: deleteSelectedCaps() (sync call)
    UI-->>User: Close dialog immediately
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Refactor to use React Query mutations #875 — Similar refactor of deleteCap(s) mutation usage and handlers across Caps.tsx, CapCard, and SelectedCapsBar.
• chore: fix view analytics #926 — Touches the same Caps area and CapCard prop surface; overlaps with onDelete/signature adjustments.

Poem

I nibble code like clover bright—
Snip! mutate to function’s light.
Caps hop off with tidy grace,
Spinners rest, a calmer place.
Barrel paths all neatly lined,
Deletions swift, selections kind.
Thump-thump—refactors well-aligned. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0bc2ef5 and 12b1204.

📒 Files selected for processing (4)

• apps/web/app/(org)/dashboard/caps/Caps.tsx (6 hunks)
• apps/web/app/(org)/dashboard/caps/components/CapCard/CapCard.tsx (1 hunks)
• apps/web/app/(org)/dashboard/caps/components/SelectedCapsBar.tsx (1 hunks)
• apps/web/app/(org)/dashboard/caps/components/index.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch weird-loading-state

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.