Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization system #335

Merged
merged 105 commits into from
Dec 2, 2023
Merged
Show file tree
Hide file tree
Changes from 46 commits
Commits
Show all changes
105 commits
Select commit Hold shift + click to select a range
fbc3151
fix: typo
pbkompasz Aug 18, 2023
784e44f
locales
pbkompasz Aug 20, 2023
6fb1974
feat: dark mode
pbkompasz Aug 20, 2023
58fa7b0
feat: Organization dropdown
pbkompasz Aug 20, 2023
a901e56
feat: organization store
pbkompasz Aug 20, 2023
9b4cac8
feat: Organization settings
pbkompasz Aug 20, 2023
e71e187
feat: getOrgs
pbkompasz Aug 20, 2023
53bdc70
feat: Organization dropdown
pbkompasz Aug 20, 2023
4f387df
feat: Organization settings tabs
pbkompasz Aug 20, 2023
513c56d
feat: toggle dark mode
pbkompasz Aug 20, 2023
c27828a
feat: icons
pbkompasz Aug 20, 2023
8bf49e7
fix: reactive
pbkompasz Aug 20, 2023
3f9da86
feat: redirect icon
pbkompasz Aug 20, 2023
7bc2069
components
pbkompasz Aug 20, 2023
8a6f523
feat: redirect
pbkompasz Aug 20, 2023
7453b7e
feat: get_orgs
pbkompasz Aug 20, 2023
dfd2576
Improve frontend
WcaleNieWolny Aug 30, 2023
57e021c
Members + select org + invite
WcaleNieWolny Aug 30, 2023
4da488b
Invitations + fixes for members
WcaleNieWolny Aug 31, 2023
d4ea0db
Invitations + fix for members
WcaleNieWolny Sep 1, 2023
4533a2b
deletion part 1
WcaleNieWolny Sep 1, 2023
5dcf20e
Delete member + policy
WcaleNieWolny Sep 2, 2023
7a56658
Merge branch 'main' into organization-system
WcaleNieWolny Sep 2, 2023
3d37e34
Fix base + shared table
WcaleNieWolny Sep 2, 2023
55ddbf1
Write more RLS
WcaleNieWolny Sep 3, 2023
0fb2046
Further frontend + backend RLS
WcaleNieWolny Sep 3, 2023
47a43e2
Further back end policies
WcaleNieWolny Sep 4, 2023
fddbc05
Final org system changes
WcaleNieWolny Sep 6, 2023
74fcc82
Merge branch 'main' into organization-system
WcaleNieWolny Sep 6, 2023
ab80075
Apikey scrollbar fix
WcaleNieWolny Sep 6, 2023
9bd0bec
Delete debug console.log
WcaleNieWolny Sep 6, 2023
85572a1
Do not owner as admin into organization
WcaleNieWolny Sep 6, 2023
8181d27
general fixes
WcaleNieWolny Sep 7, 2023
a7fb5f3
Remove complex if statements
WcaleNieWolny Sep 8, 2023
9b87ea4
Prevent invite owner
WcaleNieWolny Sep 9, 2023
86e2ea1
Show org dropdown only on settings
WcaleNieWolny Sep 9, 2023
37c56d3
Clear types
WcaleNieWolny Sep 9, 2023
b45e486
Remove invalid seed data
WcaleNieWolny Sep 11, 2023
df72ab9
Delete light mode switch
WcaleNieWolny Sep 11, 2023
6a9f8c0
Merge branch 'main' into organization-system
WcaleNieWolny Sep 12, 2023
0881be8
Add missing file
WcaleNieWolny Sep 12, 2023
3609e81
add missing upload_link change
WcaleNieWolny Sep 12, 2023
cfecaa3
Merge branch 'main' into organization-system
WcaleNieWolny Sep 24, 2023
3a8b81d
Fix base
WcaleNieWolny Sep 24, 2023
e0cc757
Add AI manifesto
WcaleNieWolny Sep 24, 2023
3e97098
Remove AI manifesto
WcaleNieWolny Sep 24, 2023
223a7e4
Merge branch 'main' into organization-system
WcaleNieWolny Oct 1, 2023
a785bef
Fix perms + add get orgs
WcaleNieWolny Oct 1, 2023
4f5df00
Minor fixes
WcaleNieWolny Oct 2, 2023
75d177f
dark fix
WcaleNieWolny Oct 2, 2023
20dc07d
Merge branch 'main' into organization-system
WcaleNieWolny Nov 7, 2023
3bdac72
Fixes part 1
WcaleNieWolny Nov 8, 2023
f6974ad
Fix noupdate
WcaleNieWolny Nov 8, 2023
d0db255
tests part 1
WcaleNieWolny Nov 8, 2023
34b079a
Tests part 2
WcaleNieWolny Nov 9, 2023
b09f973
Supabase admin + finish invite test
WcaleNieWolny Nov 10, 2023
ca104bf
Invite test all types
WcaleNieWolny Nov 10, 2023
bd0b58b
Fix base.sql + start working on accept invite test
WcaleNieWolny Nov 11, 2023
ab067e8
Package.json script for testing org
WcaleNieWolny Nov 11, 2023
ed36445
Test accept invite
WcaleNieWolny Nov 11, 2023
b22520c
Fix stats (no clickhouse)
WcaleNieWolny Nov 11, 2023
51658bf
Permission tests part 1 for channel
WcaleNieWolny Nov 11, 2023
eb46c89
Permission tests part 2 for channel
WcaleNieWolny Nov 12, 2023
bf63530
More tests
WcaleNieWolny Nov 12, 2023
d12b691
Clientside prevent device set custom_id
WcaleNieWolny Nov 13, 2023
ec073b4
Devices permissions for org
WcaleNieWolny Nov 13, 2023
0d179b1
Add missing files
WcaleNieWolny Nov 14, 2023
6ce7abd
More tests for device
WcaleNieWolny Nov 14, 2023
e8c4bcc
Device version overwrite finalize test
WcaleNieWolny Nov 15, 2023
01121f4
Device reactivity fix
WcaleNieWolny Nov 15, 2023
a81a93b
Start testing settings + test channel overwrite
WcaleNieWolny Nov 16, 2023
23f68ce
Test supabase value change
WcaleNieWolny Nov 17, 2023
4774908
Fix settings + add test for img upload
WcaleNieWolny Nov 18, 2023
25aad8e
Fix race condition + prevent file opener from opening
WcaleNieWolny Nov 20, 2023
1fd0fd4
Test members + fix photos upload + test set org name
WcaleNieWolny Nov 20, 2023
3dd1373
Merge branch 'main' into organization-system
WcaleNieWolny Nov 20, 2023
d1e8d8c
Changes from base into a seperate migration
WcaleNieWolny Nov 22, 2023
c1e7c78
Small fixes
WcaleNieWolny Nov 23, 2023
9dd0caf
Merge remote-tracking branch 'coworker/development' into organization…
WcaleNieWolny Nov 23, 2023
d84b139
Fix frontend tests after merge
WcaleNieWolny Nov 23, 2023
c6c64f4
Fix channel_self (multiple default channels)
WcaleNieWolny Nov 24, 2023
eeaa256
Fix tests for queue system
WcaleNieWolny Nov 25, 2023
f0828af
Fix org migrantion sql
WcaleNieWolny Nov 25, 2023
1847b85
Fix selectable disallow
WcaleNieWolny Nov 25, 2023
1ae4806
Fix selectable disallow frontend test
WcaleNieWolny Nov 25, 2023
fa33f60
Check row.lengths instead of rowCount
WcaleNieWolny Nov 25, 2023
4cbc55f
Improve setup?
WcaleNieWolny Nov 25, 2023
2ee4fef
Fix typo
WcaleNieWolny Nov 25, 2023
7113093
Make selectable tests serial
WcaleNieWolny Nov 26, 2023
728851a
More serial tests
WcaleNieWolny Nov 26, 2023
5adb9da
Fix organization store
WcaleNieWolny Nov 26, 2023
84995e6
Fix select
WcaleNieWolny Nov 26, 2023
8d3f432
skip setup for existing storage state
WcaleNieWolny Nov 26, 2023
39504c8
Downgrade playwright
WcaleNieWolny Nov 27, 2023
44b6ce4
Change channel snapshotting
WcaleNieWolny Nov 27, 2023
17b3980
Switch order to avoid the delete cascade
WcaleNieWolny Nov 27, 2023
52dfd5a
Migrate backend tests to playwright
WcaleNieWolny Nov 28, 2023
55ae74c
Import crypro
WcaleNieWolny Nov 28, 2023
d22b1cc
Latest playwright
WcaleNieWolny Nov 29, 2023
b2734e7
Get perms for apikey fn
WcaleNieWolny Nov 30, 2023
abb608b
Fix get_org_perm_for_apikey
WcaleNieWolny Dec 1, 2023
50ca1a4
Finalize CLI tests
WcaleNieWolny Dec 1, 2023
d30ed63
types
WcaleNieWolny Dec 1, 2023
58e8554
Seed apikey
WcaleNieWolny Dec 1, 2023
eec8a95
Merge remote-tracking branch 'development' into organization-system
WcaleNieWolny Dec 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export {}
declare module 'vue' {
export interface GlobalComponents {
ActionSheet: typeof import('./src/components/ActionSheet.vue')['default']
ApiKeys: typeof import('./src/components/ApiKeys.vue')['default']
AppCard: typeof import('./src/components/dashboard/AppCard.vue')['default']
AppStat: typeof import('./src/components/package/AppStat.vue')['default']
AppTable: typeof import('./src/components/tables/AppTable.vue')['default']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: Code review:

  • Patch: components.d.ts

There is a new import statement for ApiKeys.vue component added. This change updates the GlobalComponents interface in the 'vue' module declaration, adding the ApiKeys component.

Bug Risk: Low
Improvement Suggestion: N/A

LGTM! The addition of the ApiKeys component to the GlobalComponents interface looks good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: Code Review:

  • The patch adds a new import for the ApiKeys component in the components.d.ts file.
  • No bug risk identified in this patch.
  • Improvement suggestion: It would be helpful to add a comment explaining the purpose or usage of the ApiKeys component.

LGTM! The addition of the ApiKeys component import is fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: Code Review:

  • Added ApiKeys component declaration.
  • Added DropdownOrganization component declaration.
  • Added OrganizationPicker component declaration.

Bug Risk: Low

Improvement Suggestion: None

LGTM! These additions to the components.d.ts file provide necessary type declarations for the newly added components.

Expand All @@ -20,6 +21,7 @@ declare module 'vue' {
DeviceCard: typeof import('./src/components/package/DeviceCard.vue')['default']
DeviceTable: typeof import('./src/components/tables/DeviceTable.vue')['default']
Dialog: typeof import('./src/components/Dialog.vue')['default']
DropdownOrganization: typeof import('./src/components/dashboard/DropdownOrganization.vue')['default']
DropdownProfile: typeof import('./src/components/dashboard/DropdownProfile.vue')['default']
IIonCopyOutline: typeof import('~icons/ion/copy-outline')['default']
InfoRow: typeof import('./src/components/package/InfoRow.vue')['default']
Expand All @@ -32,7 +34,6 @@ declare module 'vue' {
RouterLink: typeof import('vue-router')['RouterLink']
RouterView: typeof import('vue-router')['RouterView']
Searchbar: typeof import('./src/components/Searchbar.vue')['default']
SharedApps: typeof import('./src/components/dashboard/SharedApps.vue')['default']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we deleted this?

SharedUserTable: typeof import('./src/components/tables/SharedUserTable.vue')['default']
Sidebar: typeof import('./src/components/Sidebar.vue')['default']
Spinner: typeof import('./src/components/Spinner.vue')['default']
Expand Down
34 changes: 33 additions & 1 deletion locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,26 @@ activation-validate: Validate
add: Add
add-another-app: Add your app
add-api-key: Added new API key successfully
add-member: Add Member
add-shared-user: Add shared user
add-this-code-to-you: Add this code to your project
add-your-app-to-your: Add your app to your account
add-your-first-app-t: Add your first app to your account and let's push updates !
admin: Admin
afternoon: afternoon
alert-accept-inviation: Do you accept the invitation to %ORG%?
alert-add-new-key: Select new API key type
alert-confirm-delete: Confirm Delete
alert-confirm-invite: Confirm invitation
alert-confirm-regenerate: Confirm regenerating API key
alert-delete-message: Are you sure you want to delete this
alert-denied-invite: Invitation denied
alert-generate-new-key: Please select the type of API key that you want to generate.
alert-no-invite: This invitation does no longer exist
alert-not-invited: Invalid invitation, cannot accept
alert-not-reverse-message: This action is not reversible
alert-regenerate-key: Are you sure you want to regenerate this key
alert-unknown-error: Unknown error, see dev console
allow-develoment-bui: Allow develoment build
allow-device-to-self: Allow devices to self associate
allow-emulator: Allow Emulators
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: Code Review for locales/en.yml:

  1. Line 2: Consider adding a space after the colon in "activation-validate".

    • Improvement suggestion: Change "activation-validate:" to "activation-validate: ".
  2. Line 3: Consider changing "add:" to "add-app:" for clarity and consistency with other keys.

    • Improvement suggestion: Change "add:" to "add-app:".
  3. Line 6: Consider changing "add-member:" to "add-member-invitation:" for clarity.

    • Improvement suggestion: Change "add-member:" to "add-member-invitation:".
  4. Line 10: Consider changing "alert-accept-inviation:" to "alert-accept-invitation:" for spelling correction.

    • Improvement suggestion: Change "alert-accept-inviation:" to "alert-accept-invitation:".
  5. Line 12: Consider changing "alert-confirm-invite:" to "alert-confirm-invitation:" for clarity and consistency.

    • Improvement suggestion: Change "alert-confirm-invite:" to "alert-confirm-invitation:".
  6. Line 14: Consider changing "alert-denied-invite:" to "alert-invitation-denied:" for clarity and consistency.

    • Improvement suggestion: Change "alert-denied-invite:" to "alert-invitation-denied:".
  7. Line 15: Consider changing "alert-generate-new-key:" to "alert-generate-api-key:" for clarity.

    • Improvement suggestion: Change "alert-generate-new-key:" to "alert-generate-api-key:".
  8. Line 17: Consider changing "alert-no-invite:" to "alert-invalid-invitation:" for clarity.

    • Improvement suggestion: Change "alert-no-invite:" to "alert-invalid-invitation:".
  9. Line 18: Consider changing "alert-not-invited:" to "alert-cannot-accept-invitation:" for clarity.

    • Improvement suggestion: Change "alert-not-invited:" to "alert-cannot-accept-invitation:".
  10. Line 20: Consider changing "alert-unknown-error:" to "alert-unknown-error-see-dev-console:" for clarity.

    • Improvement suggestion: Change "alert-unknown-error:" to "alert-unknown-error-see-dev-console:".
  11. No bug risk identified in the provided diff.

LGTM! The suggested improvements will enhance clarity and consistency in the localization keys.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: Code Review:

  • There are no apparent bug risks in this patch.
  • Improvement Suggestion: It would be helpful to ensure consistent language across the translations, such as using "cannot" instead of "can't" for better readability and consistency.

LGTM! The changes look good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: Code Review:

  • Bug Risk:

    • The string "alert-accept-inviation" has a typo, it should be "alert-accept-invitation".
    • The string "alert-denied-invite" has a typo, it should be "alert-denied-invitation".
    • The string "alert-no-invite" has a typo, it should be "alert-no-invitation".
    • The string "alert-not-invited" has a typo, it should be "alert-not-invited".
    • The string "alert-unknown-error" has a typo, it should be "alert-unknown-error".
    • The string "cannot-change-permission" has a typo, it should be "cannot-change-permissions".
    • The string "cannot-delete-member" has a typo, it should be "cannot-delete-members".
    • The string "cannot-delete-owner" has a typo, it should be "cannot-delete-owners".
    • The string "cannot-invite-owner" has a typo, it should be "cannot-invite-owners".
    • The string "used-to-create" has a typo, it should be "account-used-to-exist".
  • Improvement Suggestions:

    • Consider providing more context or clarification in the string "add-your-first-app-t".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: Review for locales/en.yml:

  • Bug Risk:

    • The string alert-accept-inviation has a typo in "invitation" (alert-accept-inviation: Do you accept the inviation to %ORG%?). It should be fixed to "invitation".
    • The string alert-no-invite is misspelled (alert-no-invite: This invitation does no longer exist). It should be fixed to "no longer".
    • The string cannot-change-permission has a typo in "development" (allow-develoment-bui: Allow develoment build). It should be fixed to "development".
  • Improvement Suggestions:

    • Consider providing more descriptive and user-friendly messages for some of the alerts, such as alert-confirm-invite, alert-denied-invite, alert-not-invited, alert-not-reverse-message, and alert-unknown-error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: Bug risk: None apparent.

Improvement suggestions:

  • Consider adding missing translations for the newly added strings, such as "add-member," "alert-accept-invitation," "alert-confirm-invite," "alert-denied-invite," "alert-no-invite," "alert-not-invited," "alert-unknown-error," "button-deny-invite," "button-invite," and "button-join."
  • Review and ensure consistency in the capitalization and punctuation of string translations.
  • Check for any existing translations that may need to be updated based on the changes made in this patch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: LGTM! The changes in the "en.yml" file include adding translations for new features and error messages. No significant bug risks or improvement suggestions are apparent from the provided diff snippet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: locales/en.yml:

  • Bug Risk:

    • alert-accept-inviation: Typo in the key name should be "invitation" instead of "inviation".
    • alert-confirm-invite: Typo in the key name should be "invitation" instead of "invite".
    • alert-denied-invite: Typo in the key name should be "invitation" instead of "invite".
    • alert-no-invite: Typo in the key name should be "longer" instead of "no longer".
    • alert-not-invited: Typo in the key name, it should be "Invalid invitation, cannot accept" instead of "Invitation, cannot accept".
    • alert-unknown-error: Typo in the key name, it should be "Unknown error, see dev console" instead of "Unknown error, see dev console".
    • cannot-change-permission: Typo in the key name, it should be "development" instead of "develoment".
    • cannot-delete-member: Typo in the key name, it should be "member" instead of "meber".
    • cannot-delete-owner: Typo in the key name, it should be "owner" instead of "onwer".
    • cannot-invite-owner: Typo in the key name, it should be "organization" instead of "oranization".
    • email-does-not-exist: Typo in the key name, it should be "exist" instead of "exists".
    • general-information: Typo in the key name, it should be "Information" instead of "Informations".
    • insert-invite-email: Typo in the key name, it should be "organization" instead of "oranization".
    • invite-accepted: Typo in the key name, it should be "organization" instead of "oranization".
  • Improvement Suggestions:

    • Consider adding more detailed and descriptive keys to improve clarity and understanding.

OK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: ```diff
@@ -25,19 +25,26 @@ activation-validate: Validate
add: Add
add-another-app: Add your app
add-api-key: Added new API key successfully
+add-member: Add Member
add-shared-user: Add shared user
add-this-code-to-you: Add this code to your project
add-your-app-to-your: Add your app to your account
add-your-first-app-t: Add your first app to your account and let's push updates !
admin: Admin
afternoon: afternoon
+alert-accept-inviation: Do you accept the invitation to %ORG%?
alert-add-new-key: Select new API key type
alert-confirm-delete: Confirm Delete
+alert-confirm-invite: Confirm invitation
alert-confirm-regenerate: Confirm regenerating API key
alert-delete-message: Are you sure you want to delete this
+alert-denied-invite: Invitation denied
alert-generate-new-key: Please select the type of API key that you want to generate.
+alert-no-invite: This invitation does no longer exist
+alert-not-invited: Invalid invitation, cannot accept
alert-not-reverse-message: This action is not reversible
alert-regenerate-key: Are you sure you want to regenerate this key
+alert-unknown-error: Unknown error, see dev console
allow-develoment-bui: Allow development build
allow-device-to-self: Allow devices to self-associate
allow-emulator: Allow Emulators
@@ -70,21 +77,29 @@ button-browse: Browse
button-camera: Camera
button-cancel: Cancel
button-delete: Delete
+button-deny-invite: Deny
button-go: GO
button-home: Home
+button-invite: Invite
+button-join: Accept
button-options: Options
button-regenerate: Regenerate
button-remove: Remove
button-tabs: Tabs
button-toggle_dark: Toggle dark mode
button-toggle_langs: Change languages
by-clicking-on-them: by clicking on them.
+cancel: Cancel
+cannot-change-permission: Cannot change permissions, check the browser console
cannot-delete-app: Cannot delete App
cannot-delete-app-icon: Cannot delete app icon
cannot-delete-app-version: Cannot delete app version
cannot-delete-bundle: Cannot delete bundle
cannot-delete-channel: Cannot delete channel
+cannot-delete-member: Cannot delete member, check the browser console
+cannot-delete-owner: Cannot delete owner from the organization
cannot-get-the-test-: Cannot get the test version
+cannot-invite-owner: Cannot invite owner into the organization
cannot-save-custom-i: Cannot save custom ID
cannot-set-this-vers: Cannot set this version
cannot-test-app-some: Cannot test app something wrong happened
@@ -128,7 +143,6 @@ defined-as: Defined as
defined-as-private: defined as normal
defined-as-public: defined as default
delete-account: Delete Account
-used-to-create: Account with this email used to exist, cannot recreate
deleted: deleted
details-and-logs: Details and logs
device: Device
@@ -147,6 +161,7 @@ dont-have-an-account: Don’t have an account?
download: Download
email: Email
email-address: Email address
+email-does-not-exist: This user does not exist
enabled-ab-testing: Enabled AB testing
enabled-progressive-deploy: Enabled progressive deploy
encrypted: Encrypted bundles
@@ -163,6 +178,7 @@ forgot: Forgot
forgot-check-email: Check your email to get the link to reset your password
forgot-success: Password updated successfully
from-device: from device
+general-information: General Informations
generated-new-apikey: Generated new API key!
good: Good
id: ID
@@ -171,16 +187,21 @@ in-your-project-fold: In your project folder
info: Information
informations: Informations
init-capgo-in-your-a: Init Capgo in your app
+insert-invite-email: Insert the email of the user you want to invite
install: Installed
install-the-capacito: Install the Capacitor plugin
into-your-app-folder: Into your app folder.
invalid-auth: Your login is not a match, try again.
+invalid-email: The passed email is not valid
+invite-accepted: Successfully accepted organization invitation
is-emulator: Is Emulator
is-production-app: Is Production app
+key-admin: Admin
key-all: All
key-copied: Key copied in your clipboard
key-read: Read
key-u


**Code Review:**

Bug Risk:
- There are no apparent bug risks in this patch.

Improvement Suggestions:
- Consider making the language consistent throughout the file. For example, "informations" can be changed to "information."
- Ensure that all error messages and alerts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: ```diff
locales/en.yml


Patch Review:

- **Bug Risk:** No apparent bug risks in this patch.
- **Improvement Suggestions:** None.

LGTM! The patch looks good and acceptable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: Code Review: locales/en.yml

  • Bug risk: No significant bug risks identified.
  • Improvement suggestions:
    • It is advisable to use consistent naming conventions throughout the file (e.g., "Informations" should be changed to "Information").
    • Ensure that error messages are clear and informative, especially for cases like invalid email or login mismatch.
    • Consider providing more specific error messages for certain scenarios, such as when a user tries to delete an owner from an organization.

Patch looks good. LGTM!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: Code Review: locales/en.yml

  • Risk: There doesn't seem to be any immediate bug risks in this patch.
  • Improvement suggestion: The following improvements can be made:
    • Include more specific information in alert messages to provide clearer context.
    • Use consistent naming conventions for keys (e.g., "alert-confirm-invite" vs. "alert-denied-invite").
    • Ensure error messages provide helpful information for troubleshooting.

OK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: LGTM! The changes in locales/en.yml look good. However, there are a few improvement suggestions:

  1. Consider using consistent language conventions (e.g., "invitation" vs. "invite") throughout the file.
  2. Use more descriptive and specific error messages to provide clearer information to users.
  3. Ensure that all strings are properly localized for internationalization purposes.

Overall, the changes seem acceptable and address the mentioned improvements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ChatGPT: ```diff
locales/en.yml

@@ -25,19 +25,26 @@ activation-validate: Validate
add: Add
add-another-app: Add your app
add-api-key: Added new API key successfully
+add-member: Add Member
add-shared-user: Add shared user
add-this-code-to-you: Add this code to your project
add-your-app-to-your: Add your app to your account
add-your-first-app-t: Add your first app to your account and let's push updates !
admin: Admin
afternoon: afternoon
+alert-accept-inviation: Do you accept the invitation to %ORG%?
alert-add-new-key: Select new API key type
alert-confirm-delete: Confirm Delete
+alert-confirm-invite: Confirm invitation
alert-confirm-regenerate: Confirm regenerating API key
alert-delete-message: Are you sure you want to delete this
+alert-denied-invite: Invitation denied
alert-generate-new-key: Please select the type of API key that you want to generate.
+alert-no-invite: This invitation does no longer exist
+alert-not-invited: Invalid invitation, cannot accept
alert-not-reverse-message: This action is not reversible
alert-regenerate-key: Are you sure you want to regenerate this key
+alert-unknown-error: Unknown error, see dev console
allow-develoment-bui: Allow develoment build
allow-device-to-self: Allow devices to self associate
allow-emulator: Allow Emulators
@@ -70,21 +77,29 @@ button-browse: Browse
button-camera: Camera
button-cancel: Cancel
button-delete: Delete
+button-deny-invite: Deny
button-go: GO
button-home: Home
+button-invite: Invite
+button-join: Accept
button-options: Options
button-regenerate: Regenerate
button-remove: Remove
button-tabs: Tabs
button-toggle_dark: Toggle dark mode
button-toggle_langs: Change languages
by-clicking-on-them: by clicking on them.
+cancel: Cancel
+cannot-change-permission: Cannot change permissions, check browser console
cannot-delete-app: Cannot delete App
cannot-delete-app-icon: Cannot delete app icon
cannot-delete-app-version: Cannot delete app version
cannot-delete-bundle: Cannot delete bundle
cannot-delete-channel: Cannot delete channel
+cannot-delete-member: Cannot delete member, check browser console
+cannot-delete-owner: Cannot delete owner from the organization
cannot-get-the-test-: Cannot get the test version
+cannot-invite-owner: Cannot invite owner into organization
cannot-save-custom-i: Cannot save custom ID
cannot-set-this-vers: Cannot set this version
cannot-test-app-some: Cannot test app something wrong happened
@@ -128,7 +143,6 @@ defined-as: Defined as
defined-as-private: defined as normal
defined-as-public: defined as default
delete-account: Delete Account
-used-to-create: Account with this email used to exist, cannot recreate
deleted: deleted
details-and-logs: Details and logs
device: Device
@@ -147,6 +161,7 @@ dont-have-an-account: Don’t have an account?
download: Download
email: Email
email-address: Email address
+email-does-not-exist: This user does not exist
enabled-ab-testing: Enabled AB testing
enabled-progressive-deploy: Enabled progressive deploy
encrypted: Encrypted bundles
@@ -163,6 +178,7 @@ forgot: Forgot
forgot-check-email: Check your email to get the link to reset your password
forgot-success: Password updated successfully
from-device: from device
+general-information: General Informations
generated-new-apikey: Generated new API key!
good: Good
id: ID
@@ -171,16 +187,21 @@ in-your-project-fold: In your project folder
info: Information
informations: Informations
init-capgo-in-your-a: Init Capgo in your app
+insert-invite-email: Insert email of the user you want to invite
install: Installed
install-the-capacito: Install the Capacitor plugin
into-your-app-folder: Into your app folder.
invalid-auth: Your login are not a match, try again.
+invalid-email: Passed email is not valid
+invite-accepted: Successfully accepted oranization inviation
is-emulator: Is Emulator
is-production-app: Is Production app
+key-admin: Admin
key-all: All
key-copied: Key copied in your clipboard
key-read: Read
key-u


Code review:
- It seems that there are new translations added for "add-member", "alert-accept-invitation", "alert-denied-invite", "alert-no-invite", "alert-not-invited", "alert-unknown-error", "button-deny

Expand Down Expand Up @@ -73,21 +80,29 @@ button-browse: Browse
button-camera: Camera
button-cancel: Cancel
button-delete: Delete
button-deny-invite: Deny
button-go: GO
button-home: Home
button-invite: Invite
button-join: Accept
button-options: Options
button-regenerate: Regenerate
button-remove: Remove
button-tabs: Tabs
button-toggle_dark: Toggle dark mode
button-toggle_langs: Change languages
by-clicking-on-them: by clicking on them.
cancel: Cancel
cannot-change-permission: Cannot change permissions, check browser console
cannot-delete-app: Cannot delete App
cannot-delete-app-icon: Cannot delete app icon
cannot-delete-app-version: Cannot delete app version
cannot-delete-bundle: Cannot delete bundle
cannot-delete-channel: Cannot delete channel
cannot-delete-member: Cannot delete member, check browser console
cannot-delete-owner: Cannot delete owner from the organization
cannot-get-the-test-: Cannot get the test version
cannot-invite-owner: Cannot invite owner into organization
cannot-save-custom-i: Cannot save custom ID
cannot-set-this-vers: Cannot set this version
cannot-test-app-some: Cannot test app something wrong happened
Expand Down Expand Up @@ -132,7 +147,6 @@ defined-as: Defined as
defined-as-private: defined as normal
defined-as-public: defined as default
delete-account: Delete Account
used-to-create: Account with this email used to exist, cannot recreate
deleted: deleted
details-and-logs: Details and logs
device: Device
Expand All @@ -151,6 +165,7 @@ dont-have-an-account: Don’t have an account?
download: Download
email: Email
email-address: Email address
email-does-not-exist: This user does not exist
enabled-ab-testing: Enabled AB testing
enabled-progressive-deploy: Enabled progressive deploy
encrypted: Encrypted bundles
Expand All @@ -167,6 +182,7 @@ forgot: Forgot
forgot-check-email: Check your email to get the link to reset your password
forgot-success: Password updated successfully
from-device: from device
general-information: General Informations
generated-new-apikey: Generated new API key!
good: Good
id: ID
Expand All @@ -175,16 +191,21 @@ in-your-project-fold: In your project folder
info: Information
informations: Informations
init-capgo-in-your-a: Init Capgo in your app
insert-invite-email: Insert email of the user you want to invite
install: Installed
install-the-capacito: Install the Capacitor plugin
into-your-app-folder: Into your app folder.
invalid-auth: Your login are not a match, try again.
invalid-email: Passed email is not valid
invite-accepted: Successfully accepted oranization inviation
is-emulator: Is Emulator
is-production-app: Is Production app
key-admin: Admin
key-all: All
key-copied: Key copied in your clipboard
key-read: Read
key-upload: Upload
key-write: Write
language: Language
last-name: Last name
last-update: Last update
Expand All @@ -206,6 +227,8 @@ making-this-channel-: >-
Making this channel "normal" will need you to configure an other channel
default or let device self assign.
mau: Monthly active users
member-deleted: Successfully deleted member
members: Members
module-heading: Modules
monthly: Monthly
monthly-active-users: Monthly active users
Expand All @@ -220,6 +243,7 @@ need-more-contact-us: Need more ? Contact us for tailored plan
no-channel-linked: No channel, click to add
no-devices: No devices
no-logs: No logs
no-permission: Insufficient permissions
no-version-linked: No version, click to add
not-found: Not found
notifications: Notifications
Expand All @@ -230,6 +254,8 @@ open-channel: Open channel
open-settings: Click to open settings
open-sidebar: Open sidebar
open-this-link-to-le: Open this link to learn how to test your update
org-changes-saved: Organization updated successfully
org-invited-user: Successfully invited user to org
os-version: OS version
pages: Pages
password: Password
Expand All @@ -238,6 +264,7 @@ password-heading: Create Password
password-hint: Enter a combination of at least 6 numbers, letters and punctuations.
password-new: New Password
percent-fail: Fail percentage
permission-changed: Successfully changed user permission
personal-information: Personal Informations
plan-abtest: A / B testing
plan-bandwidth: GB Bandwidth
Expand Down Expand Up @@ -280,6 +307,7 @@ removed-apikey: API key has been successfully deleted
reset-password: Reset Password
reset-your-password: Reset your password
save: Saves
save-changes: Save Changes
search: Search
search-bundle: Search Bundle
search-bundle-id: Search by bundle ID
Expand All @@ -291,6 +319,8 @@ search-by-name: Search by name
search-device: Search device
search-user: Search User
see-usage: See usage
select-user-perms: Select user's permissions
select-user-perms-expanded: Select which permission should the invited user have
session_key: IvSessionKey
set-bundle: Set bundle to channel
settings: Settings
Expand Down Expand Up @@ -339,7 +369,9 @@ usage: Usage
usage-success: Your plan has been setup this page will be update, in few minutes
usage-title: Total
use-the-command: 'Use the command:'
used-to-create: Account with this email used to exist, cannot recreate
user: User
user-already-invited: This user is already invited to this organization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job reorganizing this

validate: Validate
version: Version
version-build: Version build
Expand Down
Loading
Loading