-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organization system #335
Organization system #335
Changes from 1 commit
fbc3151
784e44f
6fb1974
58fa7b0
a901e56
9b4cac8
e71e187
53bdc70
4f387df
513c56d
c27828a
8bf49e7
3f9da86
7bc2069
8a6f523
7453b7e
dfd2576
57e021c
4da488b
d4ea0db
4533a2b
5dcf20e
7a56658
3d37e34
55ddbf1
0fb2046
47a43e2
fddbc05
74fcc82
ab80075
9bd0bec
85572a1
8181d27
a7fb5f3
9b87ea4
86e2ea1
37c56d3
b45e486
df72ab9
6a9f8c0
0881be8
3609e81
cfecaa3
3a8b81d
e0cc757
3e97098
223a7e4
a785bef
4f5df00
75d177f
20dc07d
3bdac72
f6974ad
d0db255
34b079a
b09f973
ca104bf
bd0b58b
ab067e8
ed36445
b22520c
51658bf
eb46c89
bf63530
d12b691
ec073b4
0d179b1
6ce7abd
e8c4bcc
01121f4
a81a93b
23f68ce
4774908
25aad8e
1fd0fd4
3dd1373
d1e8d8c
c1e7c78
9dd0caf
d84b139
c6c64f4
eeaa256
f0828af
1847b85
1ae4806
fa33f60
4cbc55f
2ee4fef
7113093
728851a
5adb9da
84995e6
8d3f432
39504c8
44b6ce4
17b3980
52dfd5a
55ae74c
d22b1cc
b2734e7
abb608b
50ca1a4
d30ed63
58e8554
eec8a95
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,13 +31,19 @@ add-your-app-to-your: Add your app to your account | |
add-your-first-app-t: Add your first app to your account and let's push updates ! | ||
admin: Admin | ||
afternoon: afternoon | ||
alert-accept-inviation: Do you accept the invitation to %ORG%? | ||
alert-add-new-key: Select new API key type | ||
alert-confirm-delete: Confirm Delete | ||
alert-confirm-invite: Confirm invitation | ||
alert-confirm-regenerate: Confirm regenerating API key | ||
alert-delete-message: Are you sure you want to delete this | ||
alert-denied-invite: Invitation denied | ||
alert-generate-new-key: Please select the type of API key that you want to generate. | ||
alert-no-invite: This invitation does no longer exist | ||
alert-not-invited: Invalid invitation, cannot accept | ||
alert-not-reverse-message: This action is not reversible | ||
alert-regenerate-key: Are you sure you want to regenerate this key | ||
alert-unknown-error: Unknown error, see dev console | ||
allow-develoment-bui: Allow develoment build | ||
allow-device-to-self: Allow devices to self associate | ||
allow-emulator: Allow Emulators | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: Code Review:
LGTM! The changes look good. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: Code Review:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: Review for
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: Bug risk: None apparent. Improvement suggestions:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: LGTM! The changes in the "en.yml" file include adding translations for new features and error messages. No significant bug risks or improvement suggestions are apparent from the provided diff snippet. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: locales/en.yml:
OK There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: ```diff
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: ```diff
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: Code Review: locales/en.yml
Patch looks good. LGTM! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: Code Review: locales/en.yml
OK There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: LGTM! The changes in
Overall, the changes seem acceptable and address the mentioned improvements. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: ```diff @@ -25,19 +25,26 @@ activation-validate: Validate
|
||
|
@@ -70,9 +76,11 @@ button-browse: Browse | |
button-camera: Camera | ||
button-cancel: Cancel | ||
button-delete: Delete | ||
button-deny-invite: Deny | ||
button-go: GO | ||
button-home: Home | ||
button-invite: Invite | ||
button-join: Accept | ||
button-options: Options | ||
button-regenerate: Regenerate | ||
button-remove: Remove | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
type Primitive = string | number | boolean | bigint | symbol | null | undefined | ||
type Expand<T> = T extends Primitive ? T : { [K in keyof T]: T[K] } | ||
|
||
type OptionalKeys<T> = { | ||
[K in keyof T]-?: T extends Record<K, T[K]> ? never : K; | ||
}[keyof T] | ||
|
||
type RequiredKeys<T> = { | ||
[K in keyof T]-?: T extends Record<K, T[K]> ? K : never; | ||
}[keyof T] & | ||
keyof T | ||
|
||
type RequiredMergeKeys<T, U> = RequiredKeys<T> & RequiredKeys<U> | ||
|
||
type OptionalMergeKeys<T, U> = | ||
| OptionalKeys<T> | ||
| OptionalKeys<U> | ||
| Exclude<RequiredKeys<T>, RequiredKeys<U>> | ||
| Exclude<RequiredKeys<U>, RequiredKeys<T>> | ||
|
||
type MergeNonUnionObjects<T, U> = Expand< | ||
{ | ||
[K in RequiredMergeKeys<T, U>]: Expand<Merge<T[K], U[K]>>; | ||
} & { | ||
[K in OptionalMergeKeys<T, U>]?: K extends keyof T | ||
? K extends keyof U | ||
? Expand<Merge< | ||
Exclude<T[K], undefined>, | ||
Exclude<U[K], undefined> | ||
>> | ||
: T[K] | ||
: K extends keyof U | ||
? U[K] | ||
: never; | ||
} | ||
> | ||
|
||
type MergeNonUnionArrays<T extends readonly any[], U extends readonly any[]> = Array<Expand<Merge<T[number], U[number]>>> | ||
|
||
type MergeArrays<T extends readonly any[], U extends readonly any[]> = [T] extends [never] | ||
? U extends any | ||
? MergeNonUnionArrays<T, U> | ||
: never | ||
: [U] extends [never] | ||
? T extends any | ||
? MergeNonUnionArrays<T, U> | ||
: never | ||
: T extends any | ||
? U extends any | ||
? MergeNonUnionArrays<T, U> | ||
: never | ||
: never | ||
|
||
type MergeObjects<T, U> = [T] extends [never] | ||
? U extends any | ||
? MergeNonUnionObjects<T, U> | ||
: never | ||
: [U] extends [never] | ||
? T extends any | ||
? MergeNonUnionObjects<T, U> | ||
: never | ||
: T extends any | ||
? U extends any | ||
? MergeNonUnionObjects<T, U> | ||
: never | ||
: never | ||
|
||
export type Merge<T, U> = | ||
| Extract<T | U, Primitive> | ||
| MergeArrays<Extract<T, readonly any[]>, Extract<U, readonly any[]>> | ||
| MergeObjects<Exclude<T, Primitive | readonly any[]>, Exclude<U, Primitive | readonly any[]>> | ||
|
||
export type ArrayElement<ArrayType extends readonly unknown[]> = | ||
ArrayType extends readonly (infer ElementType)[] ? ElementType : never | ||
|
||
export type Concrete<Type> = { | ||
[Property in keyof Type]-?: Type[Property]; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤖 ChatGPT: This patch introduces a set of type utility functions in the Bug risk: It's difficult to identify specific bug risks without understanding the context and usage of these types. Improvement suggestion: Consider adding more comments or documentation to explain the purpose and usage of each type and utility function. LGTM! The code seems well-structured and provides useful type merging utilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 ChatGPT: Code Review for locales/en.yml:
Line 2: Consider adding a space after the colon in "activation-validate".
Line 3: Consider changing "add:" to "add-app:" for clarity and consistency with other keys.
Line 6: Consider changing "add-member:" to "add-member-invitation:" for clarity.
Line 10: Consider changing "alert-accept-inviation:" to "alert-accept-invitation:" for spelling correction.
Line 12: Consider changing "alert-confirm-invite:" to "alert-confirm-invitation:" for clarity and consistency.
Line 14: Consider changing "alert-denied-invite:" to "alert-invitation-denied:" for clarity and consistency.
Line 15: Consider changing "alert-generate-new-key:" to "alert-generate-api-key:" for clarity.
Line 17: Consider changing "alert-no-invite:" to "alert-invalid-invitation:" for clarity.
Line 18: Consider changing "alert-not-invited:" to "alert-cannot-accept-invitation:" for clarity.
Line 20: Consider changing "alert-unknown-error:" to "alert-unknown-error-see-dev-console:" for clarity.
No bug risk identified in the provided diff.
LGTM! The suggested improvements will enhance clarity and consistency in the localization keys.