Skip to content

GL SSAOUBO_Composite at UBO binding 4 is never bound by anything #147

Open
Open
GL SSAOUBO_Composite at UBO binding 4 is never bound by anything#147
Labels
area: renderingRenderer, shaders, post processingbackend: openglSpecific to the opengl backendbugSomething isn't workingpriority: mediumWorth doing, not urgentvisualIncorrect or degraded rendering output
Milestone
0.1 Stability

Description

@CanReader
CanReader
opened on Sep 4, 2026

assets/shaders/default_shader_gl.frag:151-156 (gated at :351); include/.../ConstantBuffer.hpp:272-278

No glBindBufferBase(..., 4, ...) exists anywhere in src/Graphics/OpenGL/, and SSAOCompositeGPUData
is never uploaded by the GL renderer. The shader's SSAO composite path is permanently inert.

Combined with finding #14 (GL deferred never initializes, taking CreateSSAOResources with it), SSAO is
entirely absent from OpenGL while the settings panel still offers the toggle.

Severity: visual (dead setting).

Found by a full audit of the graphics layer. Assessed severity: visual: silent no-op.

Activity

  1. CanReader
    added this to the 0.1 Stability milestone on Sep 4, 2026
  2. CanReader
    added
    bugSomething isn't working
    area: renderingRenderer, shaders, post processing
    backend: openglSpecific to the opengl backend
    priority: mediumWorth doing, not urgent
    visualIncorrect or degraded rendering output
    on Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: renderingRenderer, shaders, post processingbackend: openglSpecific to the opengl backendbugSomething isn't workingpriority: mediumWorth doing, not urgentvisualIncorrect or degraded rendering output

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions