Skip to content

Skybox falls back to a mode that binds a null cubemap #14

Open

Description

@CanReader

When a panorama load fails, Skybox logs a warning, switches m_mode to Gradient and still sets m_initialized (Skybox.cpp:110-116). Gradient mode never creates m_cubemapTexture, but Render only checks shader validity (:125) and the command lambda captures the null RefPtr into ctx->BindTexture at :163.

DebugLineRenderer has the same shape: Initialize returns early on shader failure before s_vertices is allocated (:32 vs :50), and DrawLine's first statement dereferences s_vertices with no null check (:67). Flush and Shutdown both check; DrawLine forgot.

Activity

  1. added
    bugSomething isn't working
    area: assetsLoading, textures, models, serialization
    crashCauses a crash or hang
    priority: highSignificant impact, schedule soon
    on Aug 28, 2026
  2. added this to the 0.1 Stability milestone on Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: assetsLoading, textures, models, serializationbugSomething isn't workingcrashCauses a crash or hangpriority: highSignificant impact, schedule soon

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions