Skip to content

Remove PY3 compatibility shim #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 1 commit into from
Mar 1, 2026
Merged

Remove PY3 compatibility shim #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions metakernel/_metakernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@

warnings.filterwarnings("ignore", module="IPython.html.widgets")

PY3 = sys.version_info[0] == 3

try:
import ipywidgets as widgets # type:ignore[import-untyped]
from ipywidgets.widgets.widget import Widget # type:ignore[import-untyped]
Expand Down Expand Up @@ -146,8 +144,6 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
self.max_hist_cache = 1000
self.hist_cache: list[str] = []
kwargs = {"parent": self, "kernel": self}
if not PY3:
kwargs["shell"] = None
self.comm_manager = comm.get_comm_manager()
# widgets have changed target name in 8.x, keeping for compatibility
self.comm_manager.register_target(
Expand Down
6 changes: 2 additions & 4 deletions metakernel/magic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

_maxsize = sys.maxsize

PY3 = sys.version_info[0] == 3


class MagicOptionParser(optparse.OptionParser):
def error(self, msg: str) -> NoReturn:
Expand Down Expand Up @@ -60,7 +58,7 @@ def get_args(self, mtype: str, name: str, code: str, args: Any) -> Any:
except Exception as e:
self.kernel.Error(str(e))
return self
arg_spec = inspect.getfullargspec(func) if PY3 else inspect.getargspec(func)
arg_spec = inspect.getfullargspec(func)
fargs = arg_spec.args
if fargs[0] == "self":
fargs = fargs[1:]
Expand All @@ -84,7 +82,7 @@ def call_magic(self, mtype: str, name: str, code: str, args: Any) -> Magic:
self.kernel.Error(str(e))
return self

arg_spec = inspect.getfullargspec(func) if PY3 else inspect.getargspec(func)
arg_spec = inspect.getfullargspec(func)
fargs = arg_spec.args
if fargs[0] == "self":
fargs = fargs[1:]
Expand Down
Loading