Merged
Conversation
Drop the `PY3 = sys.version_info[0] == 3` variable and all conditional branches that relied on it, since Python 2 is no longer supported.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
+ Coverage 86.59% 86.64% +0.05%
==========================================
Files 51 51
Lines 2797 2793 -4
Branches 388 387 -1
==========================================
- Hits 2422 2420 -2
+ Misses 257 256 -1
+ Partials 118 117 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PY3 = sys.version_info[0] == 3from_metakernel.pyandmagic.pyif not PY3: kwargs["shell"] = Nonebranch inMetaKernel.__init__inspect.getfullargspec(func) if PY3 else inspect.getargspec(func)calls to justinspect.getfullargspec(func)Since only Python 3 is supported, these shims are dead code.