fix(comment): moved waline placeholder parameter to locale.placeholder
#914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, It seems that there is no |
Yes, that must have been removed as well. If you find out what the new key of this option is, please open a new PR. |
CaiJimmy
changed the title
placeholder parameter to locale.placeholder
The change seems to be a bit big, it can't simply implement the corresponding function through add and delete key. So, can you fix it? @CaiJimmy |
|
Actually, there's a bigger issue: the current version of Waline included within this theme is |
Could you upgrade to the latest version? |
No, I don't use Waline and can't test if there are any compatibility issues with v3. |
NapalmCodes
pushed a commit
to NapalmCodes/hugo-theme-stack
that referenced
this pull request
Mar 30, 2024
* fix(sidebar): hide translations selector if only one translation available (CaiJimmy#950) hide translations menu if only one translation available * release: 3.22.0 * fix(sidebar): translation selector - avoid cast per PR CaiJimmy#950 (CaiJimmy#961) avoid cast per PR CaiJimmy#950 * feat(comments): add support for Beaudar（表达）comment system (CaiJimmy#931) https://beaudar.lipk.org/ * fix(comment): moved waline `placeholder` parameter to `locale.placeholder` (CaiJimmy#914) fix waline parameter * fix(sidebar): improve accessibility of sidebar bottom menu (CaiJimmy#925) * fix(menu): <ol> containing other than <li>, <script> or <template> elements * fix(menu): add title to language select menu * release: 3.23.0 * fix(i18n): add missing `zh-cn` translations (CaiJimmy#964) * feat: update Hugo version and minimum version requirement to 0.123.0 (CaiJimmy#970) * fix: `.Site.LastChange` deprecation (CaiJimmy#968) Fix the deprecation warning emitted from Hugo, and fix the typo in ` exampleSite/content/page/about/index.md` * feat: bump KaTeX to latest released version `0.16.9` (CaiJimmy#969) Bump KaTeX to latest released version 0.16.9 * fix(sidebar): menu-bottom-section not showing in mobile (CaiJimmy#966) * fix(sidebar): Bottom section not showing in mobile * fix(sidebar): Align bottom section to bottom * fix(sidebar): Gap missing in bottom section * refactor(sidebar): Simplify styles * refactor(sidebar): Remove useless padding-left * refactor(sidebar): Remove useless margin-top * refactor(sidebar): Combine duplicate flex-direction * refactor(sidebar): Remove redundant width * release: 3.24.0 * fix(head): prevent Go template from escaping HTML entities in meta description (CaiJimmy#973) * fix: favicon does not load if baseurl includes a subfolder (CaiJimmy#972) Use relURL https://gohugo.io/functions/urls/relurl/ * release: 3.24.1 * fix: remove `\n` character from meta description (CaiJimmy#980) * fix: deprecation warning for `.Site.Author` (CaiJimmy#979) Fix deprecation warning for .Site.Author, deprecated in Hugo 0.124.0 * release 3.24.2 * fix: use page resource permalink in link image (CaiJimmy#990) closes CaiJimmy#982 * docs: update some invalid documentation links (CaiJimmy#983) Update some documentation links (some were dead links) * feat(i18n): update translations for `ja` (CaiJimmy#984) * feat(i18n): update translations for `ja` * Apply review suggestions * fix(i18n): wrap `footer.builtWith` with double quotes in Japanese translation (CaiJimmy#991) * feat: add anchor link to markdown heading (CaiJimmy#992) closes CaiJimmy#935 * fix: rename `.social-menu` to `.menu-social` to avoid being blocked by ad blockers (CaiJimmy#993) closes CaiJimmy#924 * fix: make KaTeX render all math inside `document.body` (CaiJimmy#994) Since it only accepts one element, I cannot pass `.article-content` and `#TableOfContent` to it. The official documentation uses `document.body` directly, so I guess that's fine. closes CaiJimmy#882 * release: 3.25.0 * Fix to dark mode toggle * Style fixes * Style fixes * Style fix * Tweak * Fix * Remove hash sign * Make sub heading text the anchor --------- Co-authored-by: James McMurry <jmcmurry@semanticnoise.com> Co-authored-by: Jimmy Cai <hi@jimmycai.com> Co-authored-by: Jiarong Hong <64763790+hongjr03@users.noreply.github.com> Co-authored-by: L-Super <40905056+L-Super@users.noreply.github.com> Co-authored-by: Jiahao Li <42709836+TheJiahao@users.noreply.github.com> Co-authored-by: Zeyu Huang <fhfuih@outlook.com> Co-authored-by: Andreas Deininger <andreas@deininger.net> Co-authored-by: Andrew Doering <delize@users.noreply.github.com> Co-authored-by: andrewmoise <andrew.moise@gmail.com> Co-authored-by: Shun Sakai <sorairolake@protonmail.ch>
Kouni
pushed a commit
to Kouni/hugo-theme-stack
that referenced
this pull request
Feb 8, 2025
…lder` (CaiJimmy#914) fix waline parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: https://waline.js.org/en/cookbook/customize/locale.html